From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0B9A23ED5A for ; Mon, 23 Jun 2025 10:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750674759; cv=none; b=GDa8MDyXtgUS6r+DAsZzJ2BP5NMiLhqtuAfWfnGSIml1OlwusGu+1DaPfpDGNtcXW9TjDhnpHiOa6vAH96ekzzAjiHgn+ObstroJSIsfB0aO0FlO9Sz6OazDYRRxBxUlVTmGcLNQN8VNSKmNU4NFZP1VeJUhoW1rSQJAmfX+L2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750674759; c=relaxed/simple; bh=9oSuEk3IgnVNmP7ulXoqkKnU3sa4UTt2fu+2AkxOc24=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PGJ/IsALT+vbMXp534CmhAk14IlOvBzFCTLXdIl6vk8+ANPHocrFRNbSmimeV079pVyiVowRk0sCP13F2sbNNJl4MwJLs0rPZKuAhkZ0kr0SBKqWwTreRkO9jv7CgGbd53wFpG3+kC+5Xsy2D5Uoan2+2Z21lO5l5xb6Cs7tyA4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=DWuTGUox; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=5EnSzw8w; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=aEUTumPZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=1d3IAIYP; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="DWuTGUox"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="5EnSzw8w"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="aEUTumPZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="1d3IAIYP" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E2C902118C; Mon, 23 Jun 2025 10:32:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750674755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f57r8d/AFiQ0XBsDFZ4dPmeKn9vTf3pQy900Pa2KyZo=; b=DWuTGUoxaCrGB4ZzU8OD98g63BObGagpz2yRyFKqYQOBbSYf+gvwYGHdxWCnNYg8/HeAC2 14Tnsp2aMVykJAJcMnbNQiuP/timY5SUYV/ZZ9aqLHXxmmu/AYtO10zCeAvcaUBa6mxygY eNVXnRUhIIy3JjP5kdCICZKC9yhL92s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750674755; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f57r8d/AFiQ0XBsDFZ4dPmeKn9vTf3pQy900Pa2KyZo=; b=5EnSzw8wW+4ABx4NP8f91gPOhBS/DemsYa7TwJaBkybyOrpsbpwiZlZ291qRHHgi+jLzqK XSEuDRszI4pXaIDA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aEUTumPZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1d3IAIYP DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750674754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f57r8d/AFiQ0XBsDFZ4dPmeKn9vTf3pQy900Pa2KyZo=; b=aEUTumPZKSt45CYPNpsNLtj5HQKHXcfc+MD861zKiQ7uibwzJ/WqxKfAw9FVoONs+MMMmX LAQnmIfrCLDgs2ZwEHNdmAGe6OsYzl4+KHbmm9fj8TDnCye2/RDk+0qj5Xt4oe6DgvdY/8 ULzIit79RjELC1C6itUfnncdhm19ISA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750674754; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f57r8d/AFiQ0XBsDFZ4dPmeKn9vTf3pQy900Pa2KyZo=; b=1d3IAIYP5Bkf0+uLOX30Yp1klInmsj0i4vatB4KCMS/Tj9gG0JB8s5PtlwqIjnDXMB/UZ7 taq5vTZRAmPej/CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 472D913485; Mon, 23 Jun 2025 10:32:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id O/73D0ItWWgjIAAAD6G6ig (envelope-from ); Mon, 23 Jun 2025 10:32:34 +0000 Message-ID: Date: Mon, 23 Jun 2025 12:32:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/7] fbcon: Make a symlink to the device selected as primary To: Mario Limonciello , Bjorn Helgaas Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Lukas Wunner , Maarten Lankhorst , Maxime Ripard , David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Robin Murphy , Alex Williamson , Jaroslav Kysela , Takashi Iwai , "open list:DRM DRIVERS" , open list , "open list:INTEL IOMMU (VT-d)" , "open list:PCI SUBSYSTEM" , "open list:VFIO DRIVER" , "open list:SOUND" , Daniel Dadap , Mario Limonciello References: <20250620024943.3415685-1-superm1@kernel.org> <20250620024943.3415685-8-superm1@kernel.org> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: E2C902118C X-Rspamd-Action: no action X-Spam-Flag: NO X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FUZZY_BLOCKED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[25]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_CC(0.00)[amd.com,gmail.com,ffwll.ch,wunner.de,linux.intel.com,kernel.org,infradead.org,8bytes.org,arm.com,redhat.com,perex.cz,suse.com,lists.freedesktop.org,vger.kernel.org,lists.linux.dev,nvidia.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:mid] X-Spam-Score: -4.51 X-Spam-Level: Hi Am 20.06.25 um 17:56 schrieb Mario Limonciello: > On 6/20/25 3:47 AM, Thomas Zimmermann wrote: >> Hi >> >> Am 20.06.25 um 04:49 schrieb Mario Limonciello: >>> From: Mario Limonciello >>> >>> Knowing which device is the primary device can be useful for userspace >>> to make decisions on which device to start a display server. >>> >>> Create a link to that device called 'primary_device'. >>> >>> Signed-off-by: Mario Limonciello >>> --- >>>   drivers/video/fbdev/core/fbcon.c | 10 +++++++++- >>>   1 file changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/ >>> core/fbcon.c >>> index 2df48037688d1..46f21570723e5 100644 >>> --- a/drivers/video/fbdev/core/fbcon.c >>> +++ b/drivers/video/fbdev/core/fbcon.c >> >> You cannot rely on this, as fbcon might be disabled entirely. > > So the other idea I had was to have a new file boot_console. 'console' already has a meaning, so I'd prefer boot_display. Apart from naming, this is a good idea. > > How would you feel about this instead (or even in addition to the > symlink)? We likely won't need the symlink then. Best regards Thomas > > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > index 268c69daa4d5..8535950b4c0f 100644 > --- a/drivers/pci/pci-sysfs.c > +++ b/drivers/pci/pci-sysfs.c > @@ -30,6 +30,7 @@ >  #include >  #include >  #include > +#include >  #include "pci.h" > >  #ifndef ARCH_PCI_DEV_GROUPS > @@ -679,6 +680,13 @@ const struct attribute_group *pcibus_groups[] = { >         NULL, >  }; > > +static ssize_t boot_console_show(struct device *dev, struct > device_attribute *attr, > +                                char *buf) > +{ > +       return sysfs_emit(buf, "%u\n", video_is_primary_device(dev)); > +} > +static DEVICE_ATTR_RO(boot_console); > + >  static ssize_t boot_vga_show(struct device *dev, struct > device_attribute *attr, >                              char *buf) >  { > @@ -1698,6 +1706,7 @@ late_initcall(pci_sysfs_init); > >  static struct attribute *pci_dev_dev_attrs[] = { >         &dev_attr_boot_vga.attr, > +       &dev_attr_boot_console.attr, >         NULL, >  }; > > @@ -1710,6 +1719,9 @@ static umode_t pci_dev_attrs_are_visible(struct > kobject *kobj, >         if (a == &dev_attr_boot_vga.attr && pci_is_vga(pdev)) >                 return a->mode; > > +       if (a == &dev_attr_boot_console.attr && pci_is_display(pdev)) > +               return a->mode; > + >         return 0; >  } > > >> >> Best regards >> Thomas >> >>> @@ -2934,7 +2934,7 @@ static void fbcon_select_primary(struct >>> fb_info *info) >>>   { >>>       if (!map_override && primary_device == -1 && >>>           video_is_primary_device(info->device)) { >>> -        int i; >>> +        int i, r; >>>           printk(KERN_INFO "fbcon: %s (fb%i) is primary device\n", >>>                  info->fix.id, info->node); >>> @@ -2949,6 +2949,10 @@ static void fbcon_select_primary(struct >>> fb_info *info) >>>                      first_fb_vc + 1, last_fb_vc + 1); >>>               info_idx = primary_device; >>>           } >>> +        r = sysfs_create_link(&fbcon_device->kobj, >>> &info->device->kobj, >>> +                      "primary_device"); >>> +        if (r) >>> +            pr_err("fbcon: Failed to link to primary device: %d\n", >>> r); >>>       } >>>   } >>> @@ -3376,6 +3380,10 @@ void __init fb_console_init(void) >>>   void __exit fb_console_exit(void) >>>   { >>> +#ifdef CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY >>> +    if (primary_device != -1) >>> +        sysfs_remove_link(&fbcon_device->kobj, "primary_device"); >>> +#endif >>>   #ifdef CONFIG_FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER >>>       console_lock(); >>>       if (deferred_takeover) >> > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)