From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ED63C433E1 for ; Tue, 25 Aug 2020 11:49:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EFF22071E for ; Tue, 25 Aug 2020 11:49:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730046AbgHYLtQ (ORCPT ); Tue, 25 Aug 2020 07:49:16 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:9433 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730015AbgHYLtJ (ORCPT ); Tue, 25 Aug 2020 07:49:09 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4BbS1g3yCQz9tybg; Tue, 25 Aug 2020 13:48:39 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id P61qFMU1aYgl; Tue, 25 Aug 2020 13:48:39 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4BbS1g31k8z9tybd; Tue, 25 Aug 2020 13:48:39 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id A4CCB8B815; Tue, 25 Aug 2020 13:48:40 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id XBPx8gicxpnc; Tue, 25 Aug 2020 13:48:40 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DFC4E8B80B; Tue, 25 Aug 2020 13:48:39 +0200 (CEST) Subject: Re: [PATCH v5 4/8] powerpc/watchpoint: Move DAWR detection logic outside of hw_breakpoint.c To: Ravi Bangoria Cc: mpe@ellerman.id.au, mikey@neuling.org, paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, pedromfc@linux.ibm.com, rogealve@linux.ibm.com, jniethe5@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20200825043617.1073634-1-ravi.bangoria@linux.ibm.com> <20200825043617.1073634-5-ravi.bangoria@linux.ibm.com> <0a73280b-c231-a7bb-18d9-abf2a37ba24b@csgroup.eu> <59ac33ed-4ed3-2c92-7b0b-1d14abf7186b@linux.ibm.com> From: Christophe Leroy Message-ID: Date: Tue, 25 Aug 2020 13:48:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <59ac33ed-4ed3-2c92-7b0b-1d14abf7186b@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 25/08/2020 à 13:08, Ravi Bangoria a écrit : > Hi Christophe, > >>> +static int cache_op_size(void) >>> +{ >>> +#ifdef __powerpc64__ >>> +    return ppc64_caches.l1d.block_size; >>> +#else >>> +    return L1_CACHE_BYTES; >>> +#endif >>> +} >> >> You've got l1_dcache_bytes() in arch/powerpc/include/asm/cache.h to do >> that. >> >>> + >>> +void wp_get_instr_detail(struct pt_regs *regs, struct ppc_inst *instr, >>> +             int *type, int *size, unsigned long *ea) >>> +{ >>> +    struct instruction_op op; >>> + >>> +    if (__get_user_instr_inatomic(*instr, (void __user *)regs->nip)) >>> +        return; >>> + >>> +    analyse_instr(&op, regs, *instr); >>> +    *type = GETTYPE(op.type); >>> +    *ea = op.ea; >>> +#ifdef __powerpc64__ >>> +    if (!(regs->msr & MSR_64BIT)) >>> +        *ea &= 0xffffffffUL; >>> +#endif >> >> This #ifdef is unneeded, it should build fine on a 32 bits too. > > This patch is just a code movement from one file to another. > I don't really change the logic. Would you mind if I do a > separate patch for these changes (not a part of this series)? Sure, do it in a separate patch. Christophe