From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 016EB36DA18 for ; Mon, 8 Jun 2026 09:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780909554; cv=none; b=ladu0BkiQ3dQt7rddBXDtG6INFOMbRJskLHm4JA1o1VjtuBYo7VC28aqthg/cOiYNsi2gcZBfHWfL9HMX4oC5fc9AJDsCzgfeFULUSLPz/8mr/qW/WsE+EusJloECxOAfcd2DIF63rSTb7qhaFUFb8yHHIP031F35G6DEb0cehI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780909554; c=relaxed/simple; bh=OQYFlo/wvw+97rYQB/1SMQpN/6mX0nd5l7DZmNGPrec=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ppdYFIc+so5r2sTfeHZj1xBWVHfIxtLWiNQB0eVuanDsU5m5GPFikf7t4BNTdnQ2czt3eLZkeIvGesog2GO7M9XCihshDMG1ssRe9OVkRn1S6Mx3Bh9ij9vTfaOIUXjB+KT4Pu8mDSLeJYfz1GW3lZfld+dgLezP2sQKJXveivM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jTlG9WNl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NP/aKx+f; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jTlG9WNl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NP/aKx+f" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586RWkY2833465 for ; Mon, 8 Jun 2026 09:05:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sSSvva9xyhbhw+Xk4pnwYk8T29hV+yUkpgxYP1wpWEs=; b=jTlG9WNl7JLKg+Fy bUqRmnmhWFVi5PBAz47hJ81GdasdN2AbDuyOZZ9MDe85ZPVC0tbD6zTMx56S02p/ TaAKmX4lTtgPpc/l5F9IKBJFGMU8anCwQfEL23qQRKNwE92pNriR+YICD7uh1uvN w/37ks/smnTCDgJSQMIdRJtoLGMoRKt7mBSXpW7Vd2ApRx03m5gd/nDj5EQ9YyOu /ZcrIUJU1QlDLyM0tEZ/VCtApj1lfrdgOsI23+X6659790WiahjornmxuqfwekP7 LD6rpidN7ZXcRDrm28E1zdwCssmV0ZXM/92a1KButn5ylOjFBTtoj5oTLY+pyTz1 hU7BWg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emaj4y9b3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 09:05:51 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-517647fbff1so13923531cf.2 for ; Mon, 08 Jun 2026 02:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780909551; x=1781514351; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sSSvva9xyhbhw+Xk4pnwYk8T29hV+yUkpgxYP1wpWEs=; b=NP/aKx+fjHXVWagWmKSXzZWcDwVoxrasXmaEBbvWdr6GK3cgvwJvnTrkz9ppt82XQ1 uzCBXEOEqeDY/wGflX63/ExhNb0TW7kZZblHilDlWiM7nUcLI4IJN8k1z6ylnERTz/OP H/DNbNo+Z6g+0xxR4RoIo3BRzWn/USnznB2N5yMngTxeLs7fZfX6S1oNen4Oa14Voyos RL/0vZKBvyUf235qLw5HJqfrWH+xA7cDiDYXe9o+Oe9P87pdPhrIe767nDFuU9znNMvP EB2E8awzH9a03HAXcw3SANyrVIOQRmIsCDfdaqYjY/j0RoufnnuhlTuR4guqLuVFfwZt Cyrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780909551; x=1781514351; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sSSvva9xyhbhw+Xk4pnwYk8T29hV+yUkpgxYP1wpWEs=; b=XLh6p8gi6s/a2P3esIGlCjThUyn6KMd7DWcdH0fMp26TOZr6ZLOoIF5gxBYUYZOUJN se4Y5+C4/RLj3VcW1yEydkoaEuBWE7ysxyqDQBm/4hu9PCsmsI3ynNtA4HrA45ViS1rl Bxh75j31nUQTVuOpoay+W9Ib8246+vL6QuLxeHJ3/QjuSXV9TBjMzfWtWV+pQ2AACh9/ 6smoM7u8Iyrmmw2MXQk1TNC7Z6yVZ78L2vc1/cbbfyWTOM0GRKGjnsbbwhmxvJgKUDic Yj3sBMYqEkEq95AhgHZ9z8sgQ0YmW3VfnfyTQ8r0ctUO3ALgRl2kYSp8eZ9360r0FawW 0lZQ== X-Forwarded-Encrypted: i=1; AFNElJ95WebPTbI5A6lg7LiUWoNKWLrHssvRndW1M8VMsu8TaCzdKsZ5h8kZmNPu7lV1t8/61s6uh8DUh6mN27Q=@vger.kernel.org X-Gm-Message-State: AOJu0YykoSZAF+CHmixP21LanWRPxlLQrSeXglTmslxqLGe+T+HfnHSK U1gimeNBANLe/RH22oj4ABcNFEBLKnltkqwaw9JjoOGNI9Tb0TbpMNLubjRHdFMw8z14qUyx5CS muPp/ziOAbfgdRuwEKoiG/B7egeGptoqJlxr2vMK4Dr9xwoVliXoQI09Z72BLEw3P9gA= X-Gm-Gg: Acq92OHGJa643tS3BJTrupt8H7qwxpDF/Uzg2BcNFHyOhXr0CFSYeq2c56JgUWcZD2+ 3QAdYaIBZtYf43hf+PoSGRXUzegB3xNQo5yU1Y+jOyy3Awayc5DT6dQwAGAp6jrK7WUv8mPmgmO N7RzZpkptVRxBX63G9ZaZi4NeJFsHbG0BRwJkjAFBHGoRNCInmdqvdUueF1g8mSLZdUoxvUhuWc gJ5FE/wpe5zVVpe3UlYwpSIc9NujxHkL7kc9qX6U89UY/qLAsOgIre19MbTuQXznRq3Z7hq4o9c DkXDoK6EmS/kSrl6MtHXqkD2lfYbhTPYGnHtH6A6lzP7jQJ/so7tqubiysNZPxYQ+18g+lCBNq5 SNVpDOXRZ3seAG9A0XiC5WRJl51uIzW/yfrSTTzh1RKXGDVpCFkirq4oT X-Received: by 2002:a05:620a:6084:b0:915:7c1a:138c with SMTP id af79cd13be357-915a9d5fd58mr1326856285a.4.1780909551193; Mon, 08 Jun 2026 02:05:51 -0700 (PDT) X-Received: by 2002:a05:620a:6084:b0:915:7c1a:138c with SMTP id af79cd13be357-915a9d5fd58mr1326851785a.4.1780909550709; Mon, 08 Jun 2026 02:05:50 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf41f05041esm427079066b.62.2026.06.08.02.05.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 02:05:49 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 11:05:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: Add Glymur-based Lenovo Yoga Slim 7x Gen11 To: Gopikrishna Garmidi , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Douglas Anderson , Bjorn Andersson , Konrad Dybcio Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , Abel Vesa References: <20260604-topic-yoga_submission-v1-0-57c70c23d0d6@oss.qualcomm.com> <20260604-topic-yoga_submission-v1-3-57c70c23d0d6@oss.qualcomm.com> <6d2ca392-148a-4539-92b8-05bdab1d07e3@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <6d2ca392-148a-4539-92b8-05bdab1d07e3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: C4LXaXNpVAlZSeQzmWcaZ_yJflRsyV4M X-Proofpoint-GUID: C4LXaXNpVAlZSeQzmWcaZ_yJflRsyV4M X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA4NCBTYWx0ZWRfX5meB2NZZgWwG VlKmOE2g/Z7RZ6UW6UyttLs2FLjR0/IHri0iDUrRcXXm87sVHglmbWwykPI6IE6sGBogTc8wG7m pJ1mGlLxB/6LXTTuqNvrqnXL55pEkW8dOFq608PbImKx1BgiL0tn2gAAW1mkDiIGsS8TbXTC9pv 1bS0YOCiu/0Cq3tb3bdB+CZCvDWSR0nTsyZt78/ShZoxrox4q3T0jFLyMeXjk/Age78Q98CKKYQ uCRXRgTIwXbR+n9u7/EiQDKGSur9Ns5JjXH7rKTWmrC5eiM5u9ZUednv3DgUa0FwVwVkVYAAkcB wvnXQruyOgARC7+vmA/Y1VBFa8z3GB5p/J31X8N4/5btbB6TT6/4YErwcFogKeo7BqMt5Dq/nzI HeHsJOidciLrOZ1L5aWQFWOEzD7URakNdAGnXODBL4oZag+VlmQ3GuvG6e/DCmsKsPpHnku/cvr qUQUdrV2y0UB0csEUQQ== X-Authority-Analysis: v=2.4 cv=TLh1jVla c=1 sm=1 tr=0 ts=6a2685ef cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=kKXrk63Xix4RLwVNwpMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080084 On 6/4/26 11:59 AM, Gopikrishna Garmidi wrote: > > > On 6/4/2026 1:36 PM, Konrad Dybcio wrote: >> Introduce a device tree for the Glymur-based Lenovo Yoga Slim 7x Gen11 >> laptop. It's fairly similar to the reference design, although there are >> a couple of major differences, including a different EC. [...] >> +&pmh0101_gpios { >> +    key_vol_up_default: key-vol-up-default-state { >> +        pins = "gpio6"; >> +        function = "normal"; >> +        output-disable; >> +        bias-pull-up; >> +    }; >> +}; > The &pmh0101_gpios node is extended twice here. Please merge both > pinctrl states into a single block, similar to the fix already sent > for glymur-crd.dtsi [1]. Thanks! I'll just skip it here, as there's probably a RESIN input on the debug connector, but it's not soldered (we didn't use it) so it doesn't really make sense to poke at it unless someone really wants to go the extra mile > > While at it, could you also take a look at [1]? It addresses the > same issue in glymur-crd.dtsi and has been awaiting review. > > [1] https://lore.kernel.org/all/20260602-merge-duplicate-pmh0101-gpios-node-v2-1-251107b3d9fe@oss.qualcomm.com/ I was under the impression I've already done that, but rb'd it now. Konrad