From: Johannes Thumshirn <jthumshirn@suse.de>
To: Jerry Hoemann <jerry.hoemann@hpe.com>, dan.j.williams@intel.com
Cc: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH 3/3] libnvdimm: New ACPI 6.2 DSM functions
Date: Thu, 8 Jun 2017 10:02:10 +0200 [thread overview]
Message-ID: <f9c399bb-7ef7-7a95-cbf4-5937a8737b92@suse.de> (raw)
In-Reply-To: <1fa949387694a4b6200309d592e78f435f065f75.1496852665.git.jerry.hoemann@hpe.com>
On 06/07/2017 07:04 PM, Jerry Hoemann wrote:
> @@ -179,6 +217,10 @@ static inline const char *nvdimm_bus_cmd_name(unsigned cmd)
> [ND_CMD_ARS_START] = "ars_start",
> [ND_CMD_ARS_STATUS] = "ars_status",
> [ND_CMD_CLEAR_ERROR] = "clear_error",
> + [5] = "trans_spa",
> + [7] = "ars_err_inj",
> + [8] = "ars_err_inj_clr",
> + [9] = "ars_err_inj_stat",
> [ND_CMD_CALL] = "cmd_call",
> };
Can you please add the new values to the enum in uapi/ndctl.h? I don't
really like the magic numbers here.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-06-08 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 17:04 [PATCH 0/3] Enable DSM pass thru for root functions Jerry Hoemann
2017-06-07 17:04 ` [PATCH 1/3] libnvdimm: passthru functions clear to send Jerry Hoemann
2017-06-07 17:04 ` [PATCH 2/3] acpi, nfit: Enable DSM pass thru for root functions Jerry Hoemann
2017-06-07 17:04 ` [PATCH 3/3] libnvdimm: New ACPI 6.2 DSM functions Jerry Hoemann
2017-06-08 8:02 ` Johannes Thumshirn [this message]
2017-06-09 5:28 ` Dan Williams
2017-06-09 16:59 ` Jerry Hoemann
2017-06-09 17:13 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9c399bb-7ef7-7a95-cbf4-5937a8737b92@suse.de \
--to=jthumshirn@suse.de \
--cc=dan.j.williams@intel.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®