From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D43823B6C00 for ; Wed, 29 Jul 2026 19:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785352660; cv=none; b=jdOIe/lSq5/nbCETPEYcesci+btnsRy0il6u62aev3HYJ5/00nS5ZywhNSk0KgPji9siHieTmZ03vEi9uG01Wli9NEI1he5h6hxyrkSJym5b9CdM8aardZOuz4lKPdSmDExd13RfhwSjHGupe6BqfVy3NGsQKLz8VmLzv0hT/4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785352660; c=relaxed/simple; bh=CnZq6n4lbArF4xO3Li8H/zaf5RFPjl2mChGqONYhzMI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uIEDqd90ibCLOwnae5A6v+EZvluPGF7Qsps0qlyIKpFJ+M5ag1en1qn0hewooJNlWkp4rabi+DLPdQAgvTF4D0/Rt5fJzbUY7rbX+q0veYrNMdk9xmhPseaJ3eUuS11krDeiUN9TguOUDiXRgZkGFpsg09aIGuL1iRGj7Q4yjhE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oNNhxrPp; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oNNhxrPp" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ccf2360620so13222595ad.3 for ; Wed, 29 Jul 2026 12:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785352656; x=1785957456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aoqhwluyb9WMKHWbPCTqTwB3rnIRyxwcbgywXIfiH+8=; b=oNNhxrPp2F7fpTFp3FNqmTvgzVrbM9vnTEizDwS8/OjTaTVib5eYj28HWuK08X+XIM /roOWh93JVyPrj7fjHIXSHMlPEC6GCHueDambTdK6XqkONXMX9ufNNIPJJXxAcMF3ByL 5Tyl5/n4x8Z9nErMKv5KzPboAZDQMyKwVsMO1HX2eUdbl7bWPFiPisQBUnaChmlN9HQ+ g/Z0ww00m5gOmS/Ui/X6oLRg+s3gOcM+8NKFIOzz4Ld1qdxsaiWW/4VxTO9eIx0Wlwld Yg5/AkyNxpomUq3Flva7Esm7I4spqiCsd7i/jzRUfOQEhfLGwf1T2SVs2bLit2ONnM7X k3zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785352656; x=1785957456; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aoqhwluyb9WMKHWbPCTqTwB3rnIRyxwcbgywXIfiH+8=; b=IGCmLS9UR89OhbGcwKA3UyVpziJ5HlWaliA1mBR+UwaDlB3Tb7eesylico2Z40AQp4 H2EVjoaTG3IznNVLReDxpnT9knp0HZiv/uOwhg2U23N3uKVgQHyEshFEMHyoUX2tGEhv jaagPugWmmvL3i7g+u9EspodQ+yonVMlCL3QYQE/vTnepQoPBw5d3vxDCiotKVheIylg MqOgwicfbIcrWCnEe2ZXBMc4S9LqArKVdLkA1UWlyN2Tcu7rLzmajJRx4egKqHiqsLO/ kDYY/NtVt1CzcDkJ0nBhc3kX8eOo2VkkAQdcKKarSKKvUC4I/jGXtuid/VKYOaU0M0Mg BqpA== X-Forwarded-Encrypted: i=1; AHgh+Rq26R4XlbIwYX+yzux0+u1AooozoYl24pCTLnz5WpTpt/kCo3xZfYu4NOv3py7H22hHxfzpnHXa1BNkLWo=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq0IR9Sfd/m23TbXJDOBtNhTsbG3jVlj1qcp0rStej57TPqlqA W6vy9d8MxTX9M76AucIw0d6B5/sbNx9Gxcv44mG5L63yAnIiPXCFCJGs X-Gm-Gg: AR+sD137ty9ld+cE51mtT4dlcz/f00dYO88iSKHweMAanx/sSu4LhTCf54Bu8BoPg1t AmXez8/PkRpBMUmTvKwDMiMLSpRq4+bn29IBp/jLkoytUNoeDIOIGHhvzEmjkAUBQDj1K3lQji+ BxoJLd4I9wwAA/T5Ow+/fHf1H8UHPSFxAyLiLD6RiClG0n9iQOPcQYvkRwIuP5nX5Sq7nMXoYqO w96JoSxfv/cnlmsmFPKSrmekrxVSZW17OZuwjrfnM2L81QTX0Aeg4wbMFKKbQVSTSvbQ+VHk9gY MCfSp/EGaKhnMKU3xwlxtw+m5wNTO7ZvUxFlmR2rwyKdEor+CpoMQkn3mI5XCB2DRG1fJrcjrGq nZVOCWaM8WoHexLlFHHsIimvGIKoAanTeI8587KLQwKyDa8VwrHY6kymUVK7ycF8cLOs8zVfIHX pTrfCK3H1uBN5tT0KTwhaFLD/RqfOLROUkwqCFrfyCL/b7So2FYld7446vKoA2ZwtKZ+sT X-Received: by 2002:a17:90b:39c7:b0:387:e0db:bc24 with SMTP id 98e67ed59e1d1-38f9938b014mr120587a91.36.1785352655805; Wed, 29 Jul 2026 12:17:35 -0700 (PDT) Received: from bogon ([2408:8207:1832:1b44::c6b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f81543abfsm833349a91.4.2026.07.29.12.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 12:17:34 -0700 (PDT) Sender: Weiming Shi From: Weiming Shi To: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: virtualization@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Xiang Mei , Bobby Eshleman Subject: [PATCH v3 2/2] vsock/virtio: avoid refilling the RX queue after teardown Date: Wed, 29 Jul 2026 12:16:55 -0700 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: <20260729185831.3247971-1-bestswngs@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit b917507e5ad9 ("vsock/virtio: stop workers during the .remove()") made the RX worker jump to its common exit when rx_run is clear. That exit still refills the RX queue when the buffer count is low, so work queued across virtio_vsock_vqs_del() can add buffers after the virtqueues have been deleted. BUG: KASAN: slab-use-after-free in virtqueue_add_sgs Read of size 4 by task kworker/0:1 Workqueue: virtio_vsock virtio_transport_rx_work Call Trace: virtqueue_add_sgs (drivers/virtio/virtio_ring.c:2796) virtio_vsock_rx_fill (net/vmw_vsock/virtio_transport.c:332) virtio_transport_rx_work (net/vmw_vsock/virtio_transport.c:701) process_one_work (kernel/workqueue.c:3314) worker_thread (kernel/workqueue.c:3478) kthread (kernel/kthread.c:436) ret_from_fork (arch/x86/kernel/process.c:158) ret_from_fork_asm (arch/x86/entry/entry_64.S:245) ... Freed by task 141: kfree (mm/slub.c:6566) vp_del_vq (drivers/virtio/virtio_pci_common.c:259) vp_del_vqs (drivers/virtio/virtio_pci_common.c:285) virtio_vsock_freeze (net/vmw_vsock/virtio_transport.c:912) virtio_device_freeze (drivers/virtio/virtio.c:658) virtio_pci_freeze (drivers/virtio/virtio_pci_common.c:601) pci_pm_freeze (drivers/pci/pci-driver.c:1098) device_suspend (drivers/base/power/main.c:1968) Kernel panic - not syncing: KASAN: panic_on_warn set ... Jump to a no-refill exit when rx_run is clear, leaving the normal exit to replenish a running queue. Fixes: b917507e5ad9 ("vsock/virtio: stop workers during the .remove()") Cc: stable@vger.kernel.org Reported-by: Xiang Mei Link: https://lore.kernel.org/r/20260727035804.1860862-1-bestswngs@gmail.com Suggested-by: Stefano Garzarella Assisted-by: OpenAI-Codex:gpt-5 Signed-off-by: Weiming Shi --- net/vmw_vsock/virtio_transport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index a8e1dd95ba8c..96c9fe8d357c 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -638,7 +638,7 @@ static void virtio_transport_rx_work(struct work_struct *work) mutex_lock(&vsock->rx_lock); if (!vsock->rx_run) - goto out; + goto out_nofill; vq = vsock->vqs[VSOCK_VQ_RX]; @@ -692,6 +692,7 @@ static void virtio_transport_rx_work(struct work_struct *work) out: if (vsock->rx_buf_nr < vsock->rx_buf_max_nr / 2) virtio_vsock_rx_fill(vsock); +out_nofill: mutex_unlock(&vsock->rx_lock); } -- 2.55.0