From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13B8C433EF for ; Mon, 21 Mar 2022 14:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349477AbiCUOkg (ORCPT ); Mon, 21 Mar 2022 10:40:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349455AbiCUOkZ (ORCPT ); Mon, 21 Mar 2022 10:40:25 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA06C12E176; Mon, 21 Mar 2022 07:38:55 -0700 (PDT) X-UUID: 65bb2f0f74004d3d9c0c060ceb518971-20220321 X-UUID: 65bb2f0f74004d3d9c0c060ceb518971-20220321 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 312422891; Mon, 21 Mar 2022 22:38:50 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Mar 2022 22:38:49 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 21 Mar 2022 22:38:48 +0800 Message-ID: Subject: Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset From: Jiaxin Yu To: Tzung-Bi Shih CC: , , , , , , , , , , , , Date: Mon, 21 Mar 2022 22:38:48 +0800 In-Reply-To: References: <20220319114111.11496-1-jiaxin.yu@mediatek.com> <20220319114111.11496-4-jiaxin.yu@mediatek.com> <17e6e8895ebc1113911481c7e097b394005db123.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-03-21 at 17:21 +0800, Tzung-Bi Shih wrote: > On Mon, Mar 21, 2022 at 05:14:08PM +0800, Jiaxin Yu wrote: > > On Mon, 2022-03-21 at 11:59 +0800, Tzung-Bi Shih wrote: > > > On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote: > > > > @@ -1145,6 +1140,13 @@ static int > > > > mt8192_mt6359_dev_probe(struct > > > > platform_device *pdev) > > > > goto err_speaker_codec; > > > > } > > > > > > > > + headset_codec = of_get_child_by_name(pdev->dev.of_node, > > > > "mediatek,headset-codec"); > > > > + if (!headset_codec) { > > > > + ret = -EINVAL; > > > > + dev_err_probe(&pdev->dev, ret, "Property > > > > 'headset_codec' missing or invalid\n"); > > > > + goto err_headset_codec; > > > > + } > > > > > > (to be neat) Does it have any reason to prevent from using > > > of_parse_phandle() > > > but of_get_child_by_name()? > > > > "mediatek,headset-codec" is a child node of pdev->dev.of_node, so I > > use > > of_get_child_by_name() to get and pass it to > > snd_soc_of_get_dai_link_codecs(). > > "mediatek,platform" and "mediatek,hdmi-codec" are also children of > pdev->dev.of_node. I guess my question is: why doesn't it also use > of_parse_phandle() for "mediatek,headset-codec"? Did I > misunderstand? Hi Tzung-Bi, The following is from bindings, "mediatek,speaker-codec" and "mediatek,headset-codec" are sub nodes of sound but "mediatek,platform" and "mediatek,hdmi-codec" are the name of properties. So we can't get the sub node pointer through of_parse_phandle(). sound: mt8192-sound { compatible = "mediatek,mt8192_mt6359_rt1015_rt5682"; mediatek,platform = <&afe>; mediatek,hdmi-codec = <&anx_bridge_dp>; pinctrl-names = "aud_clk_mosi_off", "aud_clk_mosi_on"; pinctrl-0 = <&aud_clk_mosi_off>; pinctrl-1 = <&aud_clk_mosi_on>; mediatek,headset-codec { sound-dai = <&rt5682>; }; mediatek,speaker-codec { sound-dai = <&rt1015_l>, <&rt1015_r>; }; };