From: Russ Dill <russ.dill@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mjg@redhat.com
Subject: drivers/backlight/lcd.c vs drivers/backlight/backlight.c
Date: Fri, 19 Feb 2010 00:52:05 -0700 [thread overview]
Message-ID: <f9d2a5e11002182352ydb439c5j9684e03e6890257@mail.gmail.com> (raw)
When these were initially checked in, they were basically the same,
except one was called backlight, the other lcd, one controlled
brightness, the other contrast.
Over time, they have diverged. backlight has sysfs_notify support,
provides uevent changes, and suspend/resume support. lcd has received
set_mode support.
Having a device that has variable brightness and needs info on video
timings, I'm confused at what to do. It seems other driver writers
chose to register and lcd device and a backlight device. It seems like
there is a lot of unnecessary duplication going on here. Should I
create my driver with both interfaces? Maybe with just use lcd and
pretend contrast is brightness, or maybe use backlight and add
set_mode support.
reply other threads:[~2010-02-19 7:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9d2a5e11002182352ydb439c5j9684e03e6890257@mail.gmail.com \
--to=russ.dill@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®