mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>, Alistair Popple <apopple@nvidia.com>
Cc: nova-gpu <nova-gpu@lists.linux.dev>,
	Alice Ryhl <aliceryhl@google.com>,
	David Airlie <airlied@gmail.com>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Benno Lossin <lossin@kernel.org>, Gary Guo <gary@garyguo.net>,
	Eliot Courtney <ecourtney@nvidia.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v4 4/7] drm: nova: Add a GPU info ioctl
Date: Mon, 24 Aug 2026 13:04:30 -0700	[thread overview]
Message-ID: <f9d3f749-dacb-4cfa-acf7-e748795729a6@nvidia.com> (raw)
In-Reply-To: <DKXFCIT7WHBE.1MJV6UKAJ5VEU@kernel.org>

On 8/24/26 12:34 PM, Danilo Krummrich wrote:
> On Tue Aug 11, 2026 at 7:06 AM CEST, Alistair Popple wrote:
>>  include/uapi/drm/nova_drm.h    | 27 +++++++++++++++++++++++++++
> 
> Btw. I think it would be nice to have project to play around with and write
> tests directly on top of the uAPI before we can run the big test suites.

Yes, I think it's reasonable to do something like that. Seeing a new API
from both sides, caller and callee, is always illuminating during review,
for one thing.

> 
> When I implemented the VM_BIND uAPI for nouveau I used IGT for this (but didn't
> enjoy it too much). It turned out to be very useful to test and benchmark the
> implementation before being able to complete VK CTS.
> 
> When I sent the first nova-drm skeleton, I also submitted [1]; maybe we can
> extend this further accordingly?
> 
> I'm also open for other ideas, but I'd really like to have something like this
> as we develop nova-drm.
> 
> [1] https://gitlab.freedesktop.org/dakr/drm-test

I was thinking about where this sort of thing should go, and this
location seems as good, or slightly better than the main alternatives,
to get started anyway.

Alternatives include:

1) The kernel's kselftests (tools/testings/selftests). These are
helpful in many cases, but some minor issues include:

    a) Oddly tight coupling to kernel code, even though the whole
       point of these is to exercise the kernel from user space.
       (Otherwise, these days one would use KUnit.) I've personally
       working on mitigating the coupling-induced problems and 
       ran into other, bigger problems along the way, such as:

   b) Confused build system and an arguably wrong way of invoking
      the tests (from Make(1) !).

2) Some other github-like location to host user space tests for
   nova. The idea is, do we want to set up a well-known location
   that people should keep updated? Or let a thousand github
   small test sites bloom? 


thanks,
-- 
John Hubbard


  reply	other threads:[~2026-08-24 20:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  5:06 [PATCH v4 0/7] gpu: nova: Export parameters from nova-core to nova-drm Alistair Popple
2026-08-11  5:06 ` [PATCH v4 1/7] gpu: nova-core: Add public driver API to nova-core Alistair Popple
2026-08-11  5:06 ` [PATCH v4 2/7] drm: nova: Add DRM registration data Alistair Popple
2026-08-11  5:06 ` [PATCH v4 3/7] drm: nova: Add chipid enum to nova-drm UAPI Alistair Popple
2026-08-24 14:49   ` M Henning
2026-08-24 19:24     ` Danilo Krummrich
2026-08-11  5:06 ` [PATCH v4 4/7] drm: nova: Add a GPU info ioctl Alistair Popple
2026-08-17 20:18   ` Danilo Krummrich
2026-08-21  5:10     ` Alistair Popple
2026-08-24 19:10       ` Danilo Krummrich
2026-08-24 19:34   ` Danilo Krummrich
2026-08-24 20:04     ` John Hubbard [this message]
2026-08-11  5:06 ` [PATCH v4 5/7] drm: nova: Add usable VRAM size to " Alistair Popple
2026-08-11  5:06 ` [PATCH v4 6/7] drm: nova: Use nova-core to read VRAM_BAR_SIZE parameter Alistair Popple
2026-08-17 20:11   ` Danilo Krummrich
2026-08-21  5:13     ` Alistair Popple
2026-08-11  5:06 ` [PATCH v4 7/7] drm: nova: Expose a render node Alistair Popple

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9d3f749-dacb-4cfa-acf7-e748795729a6@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ecourtney@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®