From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751600AbcFVTyg (ORCPT ); Wed, 22 Jun 2016 15:54:36 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33006 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbcFVTy2 (ORCPT ); Wed, 22 Jun 2016 15:54:28 -0400 Subject: Re: [PATCH 4/4] HID: remove ThingM blink(1) driver To: Vivien Didelot , Jiri Kosina References: <87twglqlfq.fsf@ketchup.mtl.sfl> Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: Heiner Kallweit Message-ID: Date: Wed, 22 Jun 2016 21:54:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <87twglqlfq.fsf@ketchup.mtl.sfl> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 22.06.2016 um 17:42 schrieb Vivien Didelot: > Hi, > > Jiri Kosina writes: > >> On Tue, 21 Jun 2016, Heiner Kallweit wrote: >> >>> Now that support for ThingM blink(1) was merged into the hid-led driver >>> the dedicated driver for this device can be removed. >>> >>> Signed-off-by: Heiner Kallweit >>> --- >>> drivers/hid/Kconfig | 10 -- >>> drivers/hid/Makefile | 1 - >>> drivers/hid/hid-thingm.c | 259 ----------------------------------------------- >>> 3 files changed, 270 deletions(-) >>> delete mode 100644 drivers/hid/hid-thingm.c >>> >>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >>> index ab22090..6b08a3b 100644 >>> --- a/drivers/hid/Kconfig >>> +++ b/drivers/hid/Kconfig >>> @@ -828,16 +828,6 @@ config HID_TOPSEED >>> Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic >>> CLLRCMCE remote control. >>> >>> -config HID_THINGM >> >> Overall the patchset looks good to me. I'd suggest we keep >> CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so >> that we don't cause kernel config regressions for users who had >> CONFIG_HID_THINGM already turned on. >> >> Also adding Vivien Didelot to CC, as the author of the original driver. >> Vivien, the full set can be found in linux-input archives ( >> http://marc.info/?l=linux-input&r=1&b=201606&w=2 ) > > Thanks a lot for the follow-up Jiri. > > If you guys decide to remove hid-thingm.c, you need to update the > MAINTAINERS entry, checkpatch.pl should have warned about that. > Right, thanks for the hint. > I can hardly test the patchset now. Heiner, can you confirm me that with > your patchset, we will still see 3 led_classdev in sysfs for the > blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)? > Yes, this will still be the case. Regards, Heiner > Thanks, > > Vivien >