From: Vasant Hegde <vasant.hegde@amd.com>
To: Jinhui Guo <guojinhui.liam@bytedance.com>,
joro@8bytes.org, suravee.suthikulpanit@amd.com
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Propagate the error code returned by __modify_irte_ga() in modify_irte_ga()
Date: Fri, 21 Nov 2025 13:43:11 +0530 [thread overview]
Message-ID: <f9d5b6d5-4850-4c61-b691-3a9ce9b4eb22@amd.com> (raw)
In-Reply-To: <20251120154725.435-1-guojinhui.liam@bytedance.com>
On 11/20/2025 9:17 PM, Jinhui Guo wrote:
> The return type of __modify_irte_ga() is int, but modify_irte_ga()
> treats it as a bool. Casting the int to bool discards the error code.
>
> To fix the issue, change the type of ret to int in modify_irte_ga().
>
> Fixes: 57cdb720eaa5 ("iommu/amd: Do not flush IRTE when only updating isRun and destination fields")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jinhui Guo <guojinhui.liam@bytedance.com>
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
next prev parent reply other threads:[~2025-11-21 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 15:47 Jinhui Guo
2025-11-21 4:35 ` Ankit Soni
2025-11-21 8:13 ` Vasant Hegde [this message]
2025-11-25 14:10 ` Jörg Rödel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9d5b6d5-4850-4c61-b691-3a9ce9b4eb22@amd.com \
--to=vasant.hegde@amd.com \
--cc=guojinhui.liam@bytedance.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®