From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4E5C433DB for ; Fri, 29 Jan 2021 21:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FD1664E06 for ; Fri, 29 Jan 2021 21:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233424AbhA2VY4 (ORCPT ); Fri, 29 Jan 2021 16:24:56 -0500 Received: from smtprelay0032.hostedemail.com ([216.40.44.32]:38898 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232808AbhA2VYz (ORCPT ); Fri, 29 Jan 2021 16:24:55 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 940ED127C; Fri, 29 Jan 2021 21:24:13 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: scent97_621144b275ab X-Filterd-Recvd-Size: 2133 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Fri, 29 Jan 2021 21:24:10 +0000 (UTC) Message-ID: Subject: Re: [PATCH 2/5] bits_per_long.h: introduce SMALL_CONST() macro From: Joe Perches To: Andy Shevchenko , Yury Norov Cc: linux-m68k , Linux Kernel Mailing List , Linux-SH , Linux-Arch , Geert Uytterhoeven , Yoshinori Sato , Rich Felker , Arnd Bergmann , Dennis Zhou , Andrew Morton , Wolfram Sang , David Sterba , Andy Shevchenko , Stefano Brivio , "Ma, Jianpeng" , Wei Yang , Josh Poimboeuf , John Paul Adrian Glaubitz Date: Fri, 29 Jan 2021 13:24:09 -0800 In-Reply-To: References: <20210129204528.2118168-1-yury.norov@gmail.com> <20210129204528.2118168-4-yury.norov@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2021-01-29 at 23:10 +0200, Andy Shevchenko wrote: > On Fri, Jan 29, 2021 at 10:49 PM Yury Norov wrote: [] > > @@ -37,7 +37,7 @@ > >  #define GENMASK(h, l) \ > >         (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l)) > > > > -#define BITS_FIRST(nr) GENMASK(nr), 0) > > +#define BITS_FIRST(nr) GENMASK((nr), 0) > > How come?! It's broken otherwise with unbalanced parentheses...