From: Sui Jingfeng <suijingfeng@loongson.cn>
To: Andi Shyti <andi.shyti@linux.intel.com>,
Sui Jingfeng <15330273260@189.cn>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Christian Konig <christian.koenig@amd.com>,
Pan Xinhui <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Ben Skeggs <bskeggs@redhat.com>,
Karol Herbst <kherbst@redhat.com>, Lyude Paul <lyude@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Alex Williamson <alex.williamson@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Hawking Zhang <Hawking.Zhang@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Lijo Lazar <lijo.lazar@amd.com>,
YiPeng Chai <YiPeng.Chai@amd.com>,
Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
Somalapuram Amaranath <Amaranath.Somalapuram@amd.com>,
Bokun Zhang <Bokun.Zhang@amd.com>,
Ville Syrjala <ville.syrjala@linux.intel.com>,
Li Yi <liyi@loongson.cn>, Jason Gunthorpe <jgg@ziepe.ca>,
Kevin Tian <kevin.tian@intel.com>,
Cornelia Huck <cohuck@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
Abhishek Sahu <abhsahu@nvidia.com>, Yi Liu <yi.l.liu@intel.com>,
kvm@vger.kernel.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
loongson-kernel@lists.loongnix.cn, amd-gfx@lists.freedesktop.org,
linux-pci@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix
Date: Tue, 6 Jun 2023 10:06:15 +0800 [thread overview]
Message-ID: <f9e67fe9-a93b-75ab-1fdb-87d3783fe5fc@loongson.cn> (raw)
In-Reply-To: <ZH5epG6rfTOWT6CS@ashyti-mobl2.lan>
Hi,
On 2023/6/6 06:16, Andi Shyti wrote:
> Hi Sui,
>
> On Mon, Jun 05, 2023 at 04:58:30AM +0800, Sui Jingfeng wrote:
>> From: Sui Jingfeng <suijingfeng@loongson.cn>
>>
>> To keep consistent with vga_iostate_to_str() function, the third argument
>> of vga_str_to_iostate() function should be 'unsigned int *'.
> I think the real reason is not to keep consistent with
> vga_iostate_to_str() but because vga_str_to_iostate() is actually
> only taking "unsigned int *" parameters.
Yes, right.
my expression is not completely correct, I will update it at next version.
I think, we have the same opinion.
Originally, I also want to express the opinion.
Because, it make no sense to interpret the return value
(VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM) as int type.
IO state should be should be donate by a unsigned type.
vga_iostate_to_str() also receive unsigned type.
static const char *vga_iostate_to_str(unsigned int iostate)
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>> drivers/pci/vgaarb.c | 29 +++++++++++++++--------------
>> include/linux/vgaarb.h | 8 +++-----
>> 2 files changed, 18 insertions(+), 19 deletions(-)
>>
>> diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
>> index 5a696078b382..e40e6e5e5f03 100644
>> --- a/drivers/pci/vgaarb.c
>> +++ b/drivers/pci/vgaarb.c
>> @@ -61,7 +61,6 @@ static bool vga_arbiter_used;
>> static DEFINE_SPINLOCK(vga_lock);
>> static DECLARE_WAIT_QUEUE_HEAD(vga_wait_queue);
>>
>> -
> drop this change
OK,
This is a double blank line.
Originally, I intend to accumulate all tiny fix, commit together.
As they are trivial.
Now, Should I split this patch,
then this patch set will contain two trivial patch ?
>> static const char *vga_iostate_to_str(unsigned int iostate)
>> {
>> /* Ignore VGA_RSRC_IO and VGA_RSRC_MEM */
>> @@ -77,10 +76,12 @@ static const char *vga_iostate_to_str(unsigned int iostate)
>> return "none";
>> }
>>
>> -static int vga_str_to_iostate(char *buf, int str_size, int *io_state)
>> +static int vga_str_to_iostate(char *buf, int str_size, unsigned int *io_state)
> this is OK, it's actually what you are describing in the commit
> log, but...
>
>> {
>> - /* we could in theory hand out locks on IO and mem
>> - * separately to userspace but it can cause deadlocks */
>> + /*
>> + * we could in theory hand out locks on IO and mem
>> + * separately to userspace but it can cause deadlocks
>> + */
> ... all the rest needs to go on different patches as it doesn't
> have anything to do with what you describe.
OK,
I will wait a few days for more reviews,
I process them together, also avoid version grow too fast.
Thanks.
> Andi
--
Jingfeng
next prev parent reply other threads:[~2023-06-06 2:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 20:58 Sui Jingfeng
2023-06-04 20:58 ` [PATCH v2 2/2] vgaarb: introduce is_boot_device callback function to vga_client_register Sui Jingfeng
2023-06-05 22:16 ` [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix Andi Shyti
2023-06-06 2:06 ` Sui Jingfeng [this message]
2023-06-06 10:27 ` Sui Jingfeng
2023-06-06 11:00 ` Andi Shyti
2023-06-06 19:49 ` Bjorn Helgaas
2023-06-07 6:16 ` Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e67fe9-a93b-75ab-1fdb-87d3783fe5fc@loongson.cn \
--to=suijingfeng@loongson.cn \
--cc=15330273260@189.cn \
--cc=Amaranath.Somalapuram@amd.com \
--cc=Bokun.Zhang@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=YiPeng.Chai@amd.com \
--cc=abhsahu@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andi.shyti@linux.intel.com \
--cc=andrey.grodzovsky@amd.com \
--cc=bhelgaas@google.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=cohuck@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kherbst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liyi@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
--cc=yi.l.liu@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®