From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966683AbcHBO7b (ORCPT ); Tue, 2 Aug 2016 10:59:31 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:32858 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965624AbcHBOzh (ORCPT ); Tue, 2 Aug 2016 10:55:37 -0400 Subject: Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro To: Mark Brown , Baole Ni References: <20160802105711.703-1-baolex.ni@intel.com> <20160802143150.GC10376@sirena.org.uk> CC: , , , , , , , , , , From: "Andrew F. Davis" Message-ID: Date: Tue, 2 Aug 2016 09:51:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160802143150.GC10376@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/2016 09:31 AM, Mark Brown wrote: > On Tue, Aug 02, 2016 at 06:57:11PM +0800, Baole Ni wrote: >> I find that the developers often just specified the numeric value >> when calling a macro which is defined with a parameter for access permission. >> As we know, these numeric value for access permission have had the corresponding macro, >> and that using macro can improve the robustness and readability of the code, >> thus, I suggest replacing the numeric parameter with the macro. > > Please split these up and send them independently to the relevant > maintainers with sensible subject lines - a single 1000+ patch series is > far too large and you're CCing random people so it's hard to tell which > patches are relevant (for example the batch I'm replying to here are for > the input subsystem which I don't maintain so I'm not 100% sure why I'm > being copied here). > > With this sort of thing it's often best to send one series per directory > or something similar. > I would recommend just adding whatever script you used to find all of these to patchcheck or coccinelle, then let people familiar with each subsystem make and submit the fix-ups for each subsystem. You won't get 1000+ patches to your name, but the work still gets done and you avoid bothering a lot of people. (I got about several of these for files I've never touched :/) Thanks, Andrew