From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F66C4727C for ; Thu, 1 Oct 2020 08:37:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47F4F20780 for ; Thu, 1 Oct 2020 08:37:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731459AbgJAIhD (ORCPT ); Thu, 1 Oct 2020 04:37:03 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2934 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725892AbgJAIhC (ORCPT ); Thu, 1 Oct 2020 04:37:02 -0400 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id D5057208E5AF44931A9A; Thu, 1 Oct 2020 09:37:00 +0100 (IST) Received: from [127.0.0.1] (10.210.167.80) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 1 Oct 2020 09:37:00 +0100 From: John Garry Subject: Re: [PATCH] drivers/perf: hisi: Add identifier sysfs file To: Will Deacon CC: , , , , , , , Robin Murphy References: <1592399111-134786-1-git-send-email-john.garry@huawei.com> <20200714083216.GD4516@willie-the-truck> <67db3c30-5aaf-ac17-0256-950494f5ba88@huawei.com> <20200715083016.GB5683@willie-the-truck> Message-ID: Date: Thu, 1 Oct 2020 09:34:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20200715083016.GB5683@willie-the-truck> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.167.80] X-ClientProxiedBy: lhreml736-chm.china.huawei.com (10.201.108.87) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/07/2020 09:30, Will Deacon wrote: > Hi John, > > On Wed, Jul 15, 2020 at 09:23:19AM +0100, John Garry wrote: >>> On Wed, Jun 17, 2020 at 09:05:11PM +0800, John Garry wrote: >>>> To allow userspace to identify the specific implementation of the device, >>>> add an "identifier" sysfs file. >>>> >>>> Encoding is as follows: >>>> hi1620: 0x0 (aka hip08) >>>> hi1630: 0x30 >>>> >>>> Signed-off-by: John Garry >>> >>> I'm struggling a bit to track this. If you still think it's worth pursuing, >>> please could you post a series with a cover-letter describing what this is >>> for, a link to the userspace changes and then patches for all the PMU >>> drivers that need updating? >> >> There is no hi1630 userspace support yet. >> >> So what I can do is post updated userspace support (including hi1630), and >> then post kernel parts together for all drivers we could initially support. >> >> @Joakim, I'll pick your imx driver changes here, if you don't mind. >> >> There was an RFC from you for the SMMUv3 PMU as >>> well, and also some other "arm64" changes. >>> >> >> I hope to drop that RFC if an updated SMMUv3 spec helps us out. > Released SMMUv3.3 spec provides a PMCG_IIDR reg, which we can now use to identify the implementation: https://developer.arm.com/documentation/ihi0070/da/?lang=en So I'll look to put the userspace and kernel parts together for this now for review. Thanks, John