mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Jayesh Choudhary <j-choudhary@ti.com>,
	<linux-kernel@vger.kernel.org>, <nm@ti.com>, <j-luthra@ti.com>
Cc: <kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <u-kumar1@ti.com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add McASP nodes
Date: Tue, 25 Jun 2024 14:01:30 +0530	[thread overview]
Message-ID: <f9f5178b-1e94-489b-8e71-43b814b7252a@ti.com> (raw)
In-Reply-To: <20240619095253.290552-2-j-choudhary@ti.com>



On 19/06/24 15:22, Jayesh Choudhary wrote:
> Add McASP 0-4 instances and keep them disabled as several required
> properties are missing as they are board specific.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 80 ++++++++++++++++++++++
>  1 file changed, 80 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index fd3d3344efbe..96085dc7bc18 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -2617,4 +2617,84 @@ dss_ports: ports {
>  			 */
>  		};
>  	};
> +
> +	mcasp0: mcasp@2b00000 {
> +		compatible = "ti,am33xx-mcasp-audio";
> +		reg = <0x0 0x02b00000 0x0 0x2000>,
> +		      <0x0 0x02b08000 0x0 0x1000>;

			^^ Should be 0x00 (elsewhere as well) to be inline with rest of the file


> +		reg-names = "mpu","dat";
> +		interrupts = <GIC_SPI 544 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 545 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "tx", "rx";
> +		dmas = <&main_udmap 0xc400>, <&main_udmap 0x4400>;
> +		dma-names = "tx", "rx";
> +		clocks = <&k3_clks 265 1>;
> +		clock-names = "fck";
> +		power-domains = <&k3_pds 265 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
> +	};
> +
> +	mcasp1: mcasp@2b10000 {
> +		compatible = "ti,am33xx-mcasp-audio";
> +		reg = <0x0 0x02b10000 0x0 0x2000>,
> +		      <0x0 0x02b18000 0x0 0x1000>;
> +		reg-names = "mpu","dat";
> +		interrupts = <GIC_SPI 546 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 547 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "tx", "rx";
> +		dmas = <&main_udmap 0xc401>, <&main_udmap 0x4401>;
> +		dma-names = "tx", "rx";
> +		clocks = <&k3_clks 266 1>;
> +		clock-names = "fck";
> +		power-domains = <&k3_pds 266 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
> +	};
> +
> +	mcasp2: mcasp@2b20000 {
> +		compatible = "ti,am33xx-mcasp-audio";
> +		reg = <0x0 0x02b20000 0x0 0x2000>,
> +		      <0x0 0x02b28000 0x0 0x1000>;
> +		reg-names = "mpu","dat";
> +		interrupts = <GIC_SPI 548 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 549 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "tx", "rx";
> +		dmas = <&main_udmap 0xc402>, <&main_udmap 0x4402>;
> +		dma-names = "tx", "rx";
> +		clocks = <&k3_clks 267 1>;
> +		clock-names = "fck";
> +		power-domains = <&k3_pds 267 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
> +	};
> +
> +	mcasp3: mcasp@2b30000 {
> +		compatible = "ti,am33xx-mcasp-audio";
> +		reg = <0x0 0x02b30000 0x0 0x2000>,
> +		      <0x0 0x02b38000 0x0 0x1000>;
> +		reg-names = "mpu","dat";
> +		interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "tx", "rx";
> +		dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
> +		dma-names = "tx", "rx";
> +		clocks = <&k3_clks 268 1>;
> +		clock-names = "fck";
> +		power-domains = <&k3_pds 268 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
> +	};
> +
> +	mcasp4: mcasp@2b40000 {
> +		compatible = "ti,am33xx-mcasp-audio";
> +		reg = <0x0 0x02b40000 0x0 0x2000>,
> +		      <0x0 0x02b48000 0x0 0x1000>;
> +		reg-names = "mpu","dat";
> +		interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "tx", "rx";
> +		dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
> +		dma-names = "tx", "rx";
> +		clocks = <&k3_clks 269 1>;
> +		clock-names = "fck";
> +		power-domains = <&k3_pds 269 TI_SCI_PD_EXCLUSIVE>;
> +		status = "disabled";
> +	};
>  };

-- 
Regards
Vignesh

  reply	other threads:[~2024-06-25  8:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19  9:52 [PATCH 0/3] Enable audio for J784S4-EVM platform Jayesh Choudhary
2024-06-19  9:52 ` [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add McASP nodes Jayesh Choudhary
2024-06-25  8:31   ` Vignesh Raghavendra [this message]
2024-06-25  9:57     ` Jayesh Choudhary
2024-06-19  9:52 ` [PATCH 2/3] arm64: dts: ti: k3-j784s4-main: Add audio_refclk node Jayesh Choudhary
2024-06-19  9:52 ` [PATCH 3/3] arm64: dts: ti: k3-j784s4-evm: Enable analog audio support Jayesh Choudhary
2024-06-22  6:44   ` Vignesh Raghavendra
2024-06-24  7:52     ` Jayesh Choudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9f5178b-1e94-489b-8e71-43b814b7252a@ti.com \
    --to=vigneshr@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-choudhary@ti.com \
    --cc=j-luthra@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®