From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751909AbdANKco (ORCPT ); Sat, 14 Jan 2017 05:32:44 -0500 Received: from nbd.name ([46.4.11.11]:50931 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbdANKcm (ORCPT ); Sat, 14 Jan 2017 05:32:42 -0500 Subject: Re: [PATCH v2 5/6] arm: dts: mt2701: Add ethernet device node. To: Erin Lo , Matthias Brugger References: <1484296978-18572-1-git-send-email-erin.lo@mediatek.com> <1484296978-18572-6-git-send-email-erin.lo@mediatek.com> Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Sean Wang , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: John Crispin Message-ID: Date: Sat, 14 Jan 2017 11:32:30 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484296978-18572-6-git-send-email-erin.lo@mediatek.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Erin, small comment inline On 13/01/2017 09:42, Erin Lo wrote: > From: Sean Wang > > Add ethernet device node for MT2701. > > Signed-off-by: Sean Wang > Signed-off-by: Erin Lo > --- > arch/arm/boot/dts/mt2701-evb.dts | 40 ++++++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/mt2701.dtsi | 22 ++++++++++++++++++++++ > 2 files changed, 62 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701-evb.dts b/arch/arm/boot/dts/mt2701-evb.dts > index a483798..40abd3b 100644 > --- a/arch/arm/boot/dts/mt2701-evb.dts > +++ b/arch/arm/boot/dts/mt2701-evb.dts > @@ -28,7 +28,47 @@ > status = "okay"; > }; > > +ð { > + mac-address = [00 00 00 00 00 00]; > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gmac1_pins>; > + gmac1: mac@1 { > + compatible = "mediatek,eth-mac"; > + reg = <1>; > + phy-handle = <&phy5>; > + }; > + > + mdio-bus { > + #address-cells = <1>; > + #size-cells = <0>; > + phy5: ethernet-phy@5 { > + reg = <5>; > + phy-mode = "rgmii-rxid"; > + }; > + }; > +}; > + > &pio { > + gmac1_pins: eth@0 { > + pins_eth { > + pinmux = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + }; > + > spi_pins_a: spi0@0 { > pins_spi { > pinmux = , > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index 4f52019..3847f70 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -381,6 +381,28 @@ > #clock-cells = <1>; > }; > > + eth: ethernet@1b100000 { > + compatible = "mediatek,mt7623-eth"; > + reg = <0 0x1b100000 0 0x20000>; > + interrupts = , > + , > + ; > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > + <&apmixedsys CLK_APMIXED_TRGPLL>, > + <ðsys CLK_ETHSYS_ESW>, > + <ðsys CLK_ETHSYS_GP2>, > + <ðsys CLK_ETHSYS_GP1>; > + clock-names = "ethif", "trgpll", "esw", "gp2", "gp1"; > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > + resets = <&watchdog MT2701_TOPRGU_ETHDMA_RST>; are you sure this is correct ? on mt7623 we point the reset at ethsys and not the watchdog. John > + reset-names = "eth"; > + mediatek,ethsys = <ðsys>; > + mediatek,pctl = <&syscfg_pctl_a>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > bdpsys: syscon@1c000000 { > compatible = "mediatek,mt2701-bdpsys", "syscon"; > reg = <0 0x1c000000 0 0x1000>; >