From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: alexandre.belloni@bootlin.com, pgaj@cadence.com,
miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
aniketmaurya@google.com, Shyam-sundar.S-k@amd.com,
jarkko.nikula@linux.intel.com, wsa+renesas@sang-engineering.com,
xiaopei01@kylinos.cn, Guruvendra.Punugupati@amd.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
BMC-SW@aspeedtech.com
Subject: Re: [PATCH v2 1/2] i3c: Remove the const qualifier from i2c_msg pointer in i2c_xfers API
Date: Tue, 4 Feb 2025 10:50:34 +0100 [thread overview]
Message-ID: <f9f730b6-4620-49dd-9700-ee18f777045f@t-8ch.de> (raw)
In-Reply-To: <20250204091702.4014466-1-billy_tsai@aspeedtech.com>
Hi Billy,
On 2025-02-04 17:17:01+0800, Billy Tsai wrote:
> The change is necessary to enable the use of the
> `i2c_get_dma_safe_msg_buf()` API, which requires a non-const
> `struct i2c_msg *` to operate. The `i2c_get_dma_safe_msg_buf()` function
> ensures safe handling of I2C messages when using DMA, making it essential
> for scenarios where DMA transfers are involved. By removing the `const`
> qualifier, this patch allows drivers to prepare and manage DMA-safe
> buffers directly.
This is missing a changelog to v1 of the series.
Also I asked before why it is not possible to change the signature of
i2c_get_dma_safe_msg_buf() to accept 'const struct i2c_msg *' [0].
That looks like the nicer solution to me.
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> drivers/i3c/master/dw-i3c-master.c | 2 +-
> drivers/i3c/master/i3c-master-cdns.c | 2 +-
> drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
> drivers/i3c/master/svc-i3c-master.c | 2 +-
> include/linux/i3c/master.h | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
<snip>
[0] https://lore.kernel.org/lkml/23854752-435e-432e-ba21-caf690c0cecc@t-8ch.de/
next prev parent reply other threads:[~2025-02-04 9:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 9:17 Billy Tsai
2025-02-04 9:17 ` [PATCH v2 2/2] i3c: mipi-i3c-hci: Use I2C DMA-safe api Billy Tsai
2025-02-04 15:16 ` Mukesh Kumar Savaliya
2025-02-05 11:28 ` Jarkko Nikula
2025-02-05 16:51 ` Frank Li
2025-02-04 9:50 ` Thomas Weißschuh [this message]
2025-02-04 10:09 ` [PATCH v2 1/2] i3c: Remove the const qualifier from i2c_msg pointer in i2c_xfers API Billy Tsai
2025-02-04 16:50 ` Thomas Weißschuh
2025-02-04 16:56 ` Alexandre Belloni
2025-02-17 9:57 ` wsa+renesas
2025-02-05 16:50 ` Frank Li
2025-02-20 22:09 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9f730b6-4620-49dd-9700-ee18f777045f@t-8ch.de \
--to=linux@weissschuh.net \
--cc=BMC-SW@aspeedtech.com \
--cc=Guruvendra.Punugupati@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=aniketmaurya@google.com \
--cc=billy_tsai@aspeedtech.com \
--cc=conor.culhane@silvaco.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pgaj@cadence.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®