Re: [PATCH] drm/rcar-du: dsi: Implement DSI command TX using AXI memory access

[Marek Vasut <marek.vasut@mailbox.org>]

On 8/10/26 12:04 PM, Laurent Pinchart wrote:

Hello Laurent,

[...]

>> @@ -1276,6 +1295,13 @@ static int rcar_mipi_dsi_probe(struct platform_device *pdev)
>>   	dsi->dev = &pdev->dev;
>>   	dsi->info = of_device_get_match_data(&pdev->dev);
>>   
>> +	dsi->cmd_axi_cpu = dma_alloc_coherent(&pdev->dev, SZ_4K, &dsi->cmd_axi_dma,
>> +					      GFP_KERNEL | GFP_DMA32);
> 
> I think setting the DMA mask for the device is preferred over using
> GFP_DMA32.

I will do so.

>> +	if (!dsi->cmd_axi_cpu) {
>> +		return dev_err_probe(&pdev->dev, -ENOMEM,
>> +				     "Failed to allocate DSI AXI Access command buffer\n");
>> +	}
> 
> No need for curly braces.

Are branckets { } not required for multi-line code ?
If this was a oneliner, I would drop them.

>> +
>>   	ret = rcar_mipi_dsi_parse_dt(dsi);
> 
> The allocated memory is leaking in error paths.

Fixed in V2, thanks !

[...]

-- 
Best regards,
Marek Vasut