From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973185.qiye.163.com (mail-m1973185.qiye.163.com [220.197.31.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F5B82309AA for ; Mon, 8 Dec 2025 03:24:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.85 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765164244; cv=none; b=AeuQkXw5pUIObHUw+Z8FRFt6j2OCUHRW5BJb/tYWZuJbHQdLeEsUvOrFPLZJce053QjEHcfc6uNZd1QD97uCQxax+uPUrM+BxrFMsv2h8mg+EhrI9Q7KLS03QWigFClAE1gaLRHQpiLTyuD784wqXF9RvsEbrkq8TUw9j++bC2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765164244; c=relaxed/simple; bh=tnxYmIDyEAVBDstSTwzR9UPw4GiEtfbyeDhRaOSI8H4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MqfsaKnZY4LCwq0vs5o9ySTp0/SBcjr7NRKI5VXJ7P0CGb7nr464rL0MtxiZfBvo+luL723tF7ImlkulPoyU3hVJTavBrWZXmynz88A8v0knoahRIDkCLOoumDBsOxsb79vChy5rsUM0Beqecy1DqEmzIQtvRIhJq3EsqgY4RbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=cecY6BMM; arc=none smtp.client-ip=220.197.31.85 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="cecY6BMM" Received: from [172.16.12.51] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 2c54a2597; Mon, 8 Dec 2025 10:48:27 +0800 (GMT+08:00) Message-ID: Date: Mon, 8 Dec 2025 10:48:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] drm/rockchip: vop2: Enforce AFBC source alignment in plane_check To: Nicolas Frattaroli , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Stone References: <20251206-vop2-atomic-fixups-v2-0-7fb45bbfbebd@collabora.com> <20251206-vop2-atomic-fixups-v2-5-7fb45bbfbebd@collabora.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: <20251206-vop2-atomic-fixups-v2-5-7fb45bbfbebd@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9afbdc40e803abkunme8c07999276ba1c X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQhhISlZJS01CH0xNSUhIQkNWFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=cecY6BMMm/6gQ/2K1RDh5tRiWZKU8O38FISd7rFWq0WnaAzGqbnG74DYW/5OX76YyJibVgxlKUeGLqykw3YxcmsttDzLWEiHTXe6IUFJgUa6FeaW3BIXEZgQvOpXS5Ur6s/5zek/X261ZJ0Ct245V+GgUw3u/kOSfOEZF7DJc+Q=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=++V9Ih2XOWHzt8kN5tDYhc2K8I+ECObECwQKC4d5xqk=; h=date:mime-version:subject:message-id:from; Hello Nicolas, Daniel, On 12/7/2025 4:45 AM, Nicolas Frattaroli wrote: > From: Daniel Stone > > Planes can only source AFBC framebuffers at multiples of 4px wide on > RK3566/RK3568. Instead of clipping on all SoCs when the user asks for an > unaligned source rectangle, reject the configuration in the plane's > atomic check on RK3566/RK3568 only. > > Signed-off-by: Daniel Stone > [Make RK3566/RK3568 specific, reword message] > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index bc1ed0ffede0..e23213337104 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -1076,6 +1076,13 @@ static int vop2_plane_atomic_check(struct drm_plane *plane, > return -EINVAL; > } > > + if (vop2->version == VOP_VERSION_RK3568 && drm_is_afbc(fb->modifier) && src_w % 4) { > + drm_dbg_kms(vop2->drm, > + "AFBC source rectangles must be 4-byte aligned; is %d\n", > + src_w); > + return -EINVAL; > + } > + > return 0; > } > > @@ -1237,11 +1244,8 @@ static void vop2_plane_atomic_update(struct drm_plane *plane, > WARN_ON(src_w < 4); > WARN_ON(src_h < 4); > > - if (afbc_en && src_w % 4) { > - drm_dbg_kms(vop2->drm, "vp%d %s src_w[%d] not 4 pixel aligned\n", > - vp->id, win->data->name, src_w); > - src_w = ALIGN_DOWN(src_w, 4); > - } > + if (vop2->version == VOP_VERSION_RK3568 && drm_is_afbc(fb->modifier)) > + WARN_ON(src_w % 4); > > act_info = (src_h - 1) << 16 | ((src_w - 1) & 0xffff); > dsp_info = (dsp_h - 1) << 16 | ((dsp_w - 1) & 0xffff); > You haven't replied to Andy's comment yet [0]. [0] https://lore.kernel.org/dri-devel/7b4e26ec.75f3.19a77276b53.Coremail.andyshrk@163.com/ -- Best, Chaoyi