mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Icenowy Zheng <uwu@icenowy.me>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Mark Brown <broonie@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH drm-misc-next] drm: verisilicon: fix build failure of cursor plane code
Date: Tue, 26 May 2026 11:31:39 +0300	[thread overview]
Message-ID: <f9fb657f18365a84b5af6068334fda69e021cae6@intel.com> (raw)
In-Reply-To: <560db2df89ce7a3431b4234634cdb40c6ee017f5.camel@icenowy.me>

On Tue, 26 May 2026, Icenowy Zheng <uwu@icenowy.me> wrote:
> 在 2026-05-26二的 10:44 +0300,Jani Nikula写道:
>> On Mon, 25 May 2026, Icenowy Zheng <zhengxingda@iscas.ac.cn> wrote:
>> > The cursor plane patch was stalled for a too long time that the
>> > struct drm_atomic_state parameter of atomic modeset hooks has been
>> > changed to struct drm_atomic_commit.
>> 
>> Yeah, but that was merged in the same branch three weeks ago. Did you
>> not build the changes before pushing?
>
> Oops, I thought I built the changes before sending the patch, so I
> didn't do a build before pushing.

There's so much change going on that you always need to build right
before pushing. If someone beat you to it, and you need to pull and
rebase, you basically need to build again. You never know what and how
much changed.

BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2026-05-26  8:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25 15:36 Icenowy Zheng
2026-05-26  7:44 ` Jani Nikula
2026-05-26  7:45   ` Icenowy Zheng
2026-05-26  8:31     ` Jani Nikula [this message]
2026-05-26  7:55   ` Icenowy Zheng
2026-05-26  7:52 ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9fb657f18365a84b5af6068334fda69e021cae6@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=broonie@kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=uwu@icenowy.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®