From: "Nelson, Shannon" <shannon.nelson@amd.com>
To: Yue Haibing <yuehaibing@huawei.com>,
lingshan.zhu@kernel.org, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com
Cc: virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] vdpa: Remove unused declarations
Date: Mon, 19 Aug 2024 16:24:27 -0700 [thread overview]
Message-ID: <f9fd8da2-b429-41a7-aabf-2eec3b3b9d42@amd.com> (raw)
In-Reply-To: <20240819140930.122019-1-yuehaibing@huawei.com>
On 8/19/2024 7:09 AM, Yue Haibing wrote:
>
> There is no caller and implementation in tree.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/vdpa/ifcvf/ifcvf_base.h | 3 ---
> drivers/vdpa/pds/cmds.h | 1 -
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h
> index 0f347717021a..aa36de361c10 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_base.h
> +++ b/drivers/vdpa/ifcvf/ifcvf_base.h
> @@ -112,15 +112,12 @@ void ifcvf_write_dev_config(struct ifcvf_hw *hw, u64 offset,
> const void *src, int length);
> u8 ifcvf_get_status(struct ifcvf_hw *hw);
> void ifcvf_set_status(struct ifcvf_hw *hw, u8 status);
> -void io_write64_twopart(u64 val, u32 *lo, u32 *hi);
> void ifcvf_reset(struct ifcvf_hw *hw);
> u64 ifcvf_get_dev_features(struct ifcvf_hw *hw);
> u64 ifcvf_get_hw_features(struct ifcvf_hw *hw);
> int ifcvf_verify_min_features(struct ifcvf_hw *hw, u64 features);
> u16 ifcvf_get_vq_state(struct ifcvf_hw *hw, u16 qid);
> int ifcvf_set_vq_state(struct ifcvf_hw *hw, u16 qid, u16 num);
> -struct ifcvf_adapter *vf_to_adapter(struct ifcvf_hw *hw);
> -int ifcvf_probed_virtio_net(struct ifcvf_hw *hw);
> u32 ifcvf_get_config_size(struct ifcvf_hw *hw);
> u16 ifcvf_set_vq_vector(struct ifcvf_hw *hw, u16 qid, int vector);
> u16 ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector);
> diff --git a/drivers/vdpa/pds/cmds.h b/drivers/vdpa/pds/cmds.h
> index e24d85cb8f1c..6b1bc33356b0 100644
> --- a/drivers/vdpa/pds/cmds.h
> +++ b/drivers/vdpa/pds/cmds.h
> @@ -14,5 +14,4 @@ int pds_vdpa_cmd_init_vq(struct pds_vdpa_device *pdsv, u16 qid, u16 invert_idx,
> struct pds_vdpa_vq_info *vq_info);
> int pds_vdpa_cmd_reset_vq(struct pds_vdpa_device *pdsv, u16 qid, u16 invert_idx,
> struct pds_vdpa_vq_info *vq_info);
> -int pds_vdpa_cmd_set_features(struct pds_vdpa_device *pdsv, u64 features);
> #endif /* _VDPA_CMDS_H_ */
> --
> 2.34.1
>
Thanks!
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
next prev parent reply other threads:[~2024-08-19 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 14:09 Yue Haibing
2024-08-19 23:24 ` Nelson, Shannon [this message]
2024-09-02 2:48 ` Zhu Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9fd8da2-b429-41a7-aabf-2eec3b3b9d42@amd.com \
--to=shannon.nelson@amd.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®