From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753087AbdEIH6a (ORCPT <rfc822;w@1wt.eu>);
        Tue, 9 May 2017 03:58:30 -0400
Received: from mout.web.de ([212.227.17.12]:57172 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752850AbdEIH62 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 May 2017 03:58:28 -0400
Subject: Re: qca_debug: Reduce function calls for sequence output in
 qcaspi_info_show()
To: Stefan Wahren <stefan.wahren@i2se.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
        Philippe Reynes <tremyfr@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <9932ee63-f766-49ce-d760-9a0bd06f0657@users.sourceforge.net>
 <290d2473-73bd-70db-b6ef-c50331812f31@i2se.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <f9fef8a0-13c2-8dae-cb2a-7d39491e47f4@users.sourceforge.net>
Date: Tue, 9 May 2017 09:57:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0.1
MIME-Version: 1.0
In-Reply-To: <290d2473-73bd-70db-b6ef-c50331812f31@i2se.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:5vwQJSGjf9w8Pnkj4m2CE4OoXdUA0GqsWxyRsM0YqZQphlmlRqN
 y/d1GU3+ET2/SoCi7lf1CMzpKpsQrEhKx/d5S/EkTX9dWr144BNaFZb7fjKpfY7bjLOSvNf
 vIMom9+UdH9qRXMC549VgNFJajGCMwjiRx8SeF0bScAUko6UljpKgr85WF5kRNcKhMzo3hL
 tD657Nc6uZRhhNUs3zNcg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:VUITDGM24Bs=:YPkfyIusSj7etBl+KCqydO
 LmbqIt+Jl11CXf0f+7nnziLOO3CjFBHqOos+rgtPa2GsDm2e5YJqxVDJ9sFWRVxeXxd8Mi9i6
 DHNDLpzr22sxFQC5zpgh957MMZcJDzP5k7ZK0PBlf2Tdj91PHk2uywL1kyNA0BSBTx1jsVhng
 KtxKoy6gL4w20j1cFG3ssx5DfLrPFgiNXVOz2UiXgqFZv9wbhZ+i+796cMnj1oQIt1rslPTig
 Dc6phqXDoov9JLUcYeI2NZN25WoTDgNYMEb3slT2WnEusKSN666QlJxKOJEgHBcFdTyXTLS/7
 Gap2S09Iqm69gHYhfwNuMjmVAz3Ly/vgHkCVBoZvoTuebgfj9+Gu1bluV4Eis4ncMQqWN66uZ
 m89zALG7HofJyb0T3xnZPP+cxFIeYnk6MmvTcvW/en7fnrPjt6pb7zSdCZOh+1MRGnt8RFozh
 ELPxsp5ZUibVEw1AiqjHMW9A9JC2SA8ZMNdxfBsiTxkX0Jn+JllfGcozqOzZe8lIF6/Pc2cIk
 pkJrsdagXdARjzdI8T00s10GVQInkq03xjNqfDQhvTZr7+/Ies2QV0RAPS5TJ62TnTmKIZoSn
 7t6I3UoO4L0+/tZz++TiOmxAEEqe91Oe0TsZWpRQouQFkXDfiq1Ndp8C4mMCySyXDSPVrc1kq
 a4kyH6iby/0aB2uCV5yWU9ChSkNA2ETs9bF1LK+1373Vlzlb4sP/T7wh/2KPuwRg3SWZwnqqW
 RbbI1x0IJRbfVElYvZJgVMM4h8/ZwtXdkMuZ2S9nMLRapE3dI7Oeieu4vYByGMc7C3LGooKLA
 Ac3FGZo
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> The only benefit is a little bit higher performance.

I would prefer such a small code reduction. I am not so concerned
about an other readability impression at this place.


> But for debugfs this won't be necessary.

I would appreciate also another improvement there.

Regards,
Markus