From: Miaohe Lin <linmiaohe@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <mt4022@columbia.edu>, Naoya Horiguchi <nao.horiguchi@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Jane Chu <jane.chu@oracle.com>, Zi Yan <ziy@nvidia.com>,
Kaitao Cheng <kaitao.cheng@linux.dev>,
Mike Rapoport <rppt@kernel.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Yu Zhao <yuzhao@google.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <tz2294@columbia.edu>,
<stable@vger.kernel.org>, Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
David Hildenbrand <david@kernel.org>
Subject: Re: [PATCH v2 1/2] mm/memory-failure: don't unpoison a leaked raw_hwp_unreliable folio
Date: Thu, 19 Nov 2026 15:30:30 +0800 [thread overview]
Message-ID: <fa02b7d2-fa2c-aacc-ab16-c475885a7dfa@huawei.com> (raw)
In-Reply-To: <20261118231118.ca2d773881cd953d1efee4ca@linux-foundation.org>
On 2026/11/19 15:11, Andrew Morton wrote:
> On Thu, 19 Nov 2026 14:39:24 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
>
>>> + /*
>>> + * A hugetlb folio without reliable raw error info is leaked once it
>>> + * is freed, and its hugetlb flag may be cleared by then. Check the
>>> + * flag in folio->private, which stays set on the leaked folio.
>>> + */
>>> + if (folio_test_large(folio) &&
>>> + folio_test_hugetlb_raw_hwp_unreliable(folio))
>>
>> It might be better to add a unpoison_pr_info here?
>
> How does this look?
>
> --- a/mm/memory-failure.c~mm-memory-failure-dont-unpoison-a-leaked-raw_hwp_unreliable-folio-fix
> +++ a/mm/memory-failure.c
> @@ -2818,8 +2818,12 @@ int unpoison_memory(unsigned long pfn)
> * flag in folio->private, which stays set on the leaked folio.
> */
> if (folio_test_large(folio) &&
> - folio_test_hugetlb_raw_hwp_unreliable(folio))
> + folio_test_hugetlb_raw_hwp_unreliable(folio)) {
> + unpoison_pr_info("%#lx: cannot unpoison, poisoned subpages are unknown\n",
> + pfn, &unpoison_rs);
> +
> goto unlock_mutex;
> + }
>
Looks good to me. Thanks Andrew.
> ghp = get_hwpoison_page(p, MF_UNPOISON);
> if (!ghp) {
> _
>
>
> .
>
next prev parent reply other threads:[~2026-11-19 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 21:00 [PATCH v2 0/2] mm/hugetlb: clear the hugetlb flag before leaking a hwpoisoned folio Mani Tofigh via B4 Relay
2026-11-03 21:00 ` [PATCH v2 1/2] mm/memory-failure: don't unpoison a leaked raw_hwp_unreliable folio Mani Tofigh via B4 Relay
2026-11-19 6:39 ` Miaohe Lin
2026-11-19 7:11 ` Andrew Morton
2026-11-19 7:30 ` Miaohe Lin [this message]
2026-11-03 21:00 ` [PATCH v2 2/2] mm/hugetlb: clear the hugetlb flag before leaking a hwpoisoned folio Mani Tofigh via B4 Relay
2026-11-19 6:40 ` Miaohe Lin
2026-11-19 7:06 ` [PATCH v2 0/2] " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa02b7d2-fa2c-aacc-ab16-c475885a7dfa@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=jane.chu@oracle.com \
--cc=kaitao.cheng@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=mt4022@columbia.edu \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tz2294@columbia.edu \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®