From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: phy: socionext,uniphier: add top-level constraints
Date: Wed, 21 Aug 2024 19:31:24 +0900 [thread overview]
Message-ID: <fa07f751-06ae-44c0-8994-9634c5aa9824@socionext.com> (raw)
In-Reply-To: <20240818172835.121757-1-krzysztof.kozlowski@linaro.org>
Hi Krzysztof,
I have one comment.
On 2024/08/19 2:28, Krzysztof Kozlowski wrote:
> Properties with variable number of items per each device are expected to
> have widest constraints in top-level "properties:" block and further
> customized (narrowed) in "if:then:". Add missing top-level constraints
> for clock-names and reset-names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/phy/socionext,uniphier-ahci-phy.yaml | 8 ++++++--
> .../bindings/phy/socionext,uniphier-pcie-phy.yaml | 8 ++++++--
> .../bindings/phy/socionext,uniphier-usb3hs-phy.yaml | 7 +++++--
> .../bindings/phy/socionext,uniphier-usb3ss-phy.yaml | 7 +++++--
> 4 files changed, 22 insertions(+), 8 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> index de3cffc850bc..e34b875a1bb8 100644
> ---
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> +++
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> @@ -30,13 +30,17 @@ properties:
> minItems: 1
> maxItems: 2
>
> - clock-names: true
> + clock-names:
> + minItems: 1
> + maxItems: 6
The maxItems of clocks is 2, so it should be 2.
>
> resets:
> minItems: 2
> maxItems: 6
>
> - reset-names: true
> + reset-names:
> + minItems: 2
> + maxItems: 6
>
> allOf:
> - if:
> diff --git
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-pcie-phy.yaml
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-pcie-phy.yaml
> index b3ed2f74a414..9fc0e87c508e 100644
> ---
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-pcie-phy.yaml
> +++
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-pcie-phy.yaml
> @@ -31,13 +31,17 @@ properties:
> minItems: 1
> maxItems: 2
>
> - clock-names: true
> + clock-names:
> + minItems: 1
> + maxItems: 2
>
> resets:
> minItems: 1
> maxItems: 2
>
> - reset-names: true
> + reset-names:
> + minItems: 1
> + maxItems: 2
>
> socionext,syscon:
> $ref: /schemas/types.yaml#/definitions/phandle
> diff --git
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.yaml
> index 2107d98ace15..25c4159f86e4 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.
> yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3hs-phy.
> yaml
> @@ -34,12 +34,15 @@ properties:
> minItems: 2
> maxItems: 3
>
> - clock-names: true
> + clock-names:
> + minItems: 2
> + maxItems: 3
>
> resets:
> maxItems: 2
>
> - reset-names: true
> + reset-names:
> + maxItems: 2
>
> vbus-supply:
> description: A phandle to the regulator for USB VBUS
> diff --git
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.yaml
> index 8f5aa6238bf3..1f663e9901da 100644
> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.
> yaml
> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-usb3ss-phy.
> yaml
> @@ -35,12 +35,15 @@ properties:
> minItems: 2
> maxItems: 3
>
> - clock-names: true
> + clock-names:
> + minItems: 2
> + maxItems: 3
>
> resets:
> maxItems: 2
>
> - reset-names: true
> + reset-names:
> + maxItems: 2
>
> vbus-supply:
> description: A phandle to the regulator for USB VBUS, only for USB
> host
Other than that:
Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
I'd appreciate if it could be applied in devicetree or phy.
Thank you,
---
Best Regards
Kunihiko Hayashi
next prev parent reply other threads:[~2024-08-21 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 17:28 Krzysztof Kozlowski
2024-08-19 17:14 ` Rob Herring (Arm)
2024-08-21 10:31 ` Kunihiko Hayashi [this message]
2024-08-29 19:05 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa07f751-06ae-44c0-8994-9634c5aa9824@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mhiramat@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®