From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EAA0418A2C; Tue, 14 Jul 2026 21:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784066186; cv=none; b=LqUYqoGe799brGGIxeufMhaLORWp9BXgCl4gk9BtBa0nBVe+HfFfIBUqB6YuMEAbDobVQJVRxCGBG8q+hGiCzPAFV81yVEFuCAzgvfuTzZBrMAyCEHRbke31znZEdksMohOC00p8V6dP9GRDBjvxycipSOSWnAel4tWxRb7IRBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784066186; c=relaxed/simple; bh=lRmb6HCU9B+bp6w1hqqymNpMjfL4vxsnsvabcJ0elbk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TWai/zgUUL7sEi5r65D/oipj8i1oiNNp8KqDR47fxjYbRvAZjxgUB9khAbmODInDJOpgacVKvCufiNxdBDCc8u8rIh120n+wrPOmeYBankYJ2o8YOxg/Tcqbl+BX2op+ATYpuvhK13DuXj0+jradSyaW/eYaIg4rF+6dYrs2yqY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=oEHcraLz; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oEHcraLz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784066185; x=1815602185; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=lRmb6HCU9B+bp6w1hqqymNpMjfL4vxsnsvabcJ0elbk=; b=oEHcraLzR5WADudjhUiOdHdlc8/ntpPYhbaOiroLU+CrU978p2F5K62y jh/XYcGx2d6s6/xd6EGlmZHw+E8Wfh2vHLVZYCIu0Ui5A4MYjaDMu7gEK IKHM+9bv/KT+KORIPcowZygk+lXB6ktX/ZWThtiux4R3zEpcMkTBAjK8f Y/bd50d9HmIjqu3DME7IN8D7j9E1KQOfYf4pS+E//QWZT99cFXuHwlkjK b94LYkkj2NWJr5x/HXtYVs77wx5xt8uCoO6R+w7s/B8yhOH75KS+oayHv 6aJLgyGCA/vP5Hp+vQIhrwa8lJ43z56hDZeKZRi7gGrRuVvYSXtYn31xC A==; X-CSE-ConnectionGUID: cuwNwwDhQJKVPvOcQQUU2w== X-CSE-MsgGUID: Gb9tqQgKQAm/E5KRZ9RXiQ== X-IronPort-AV: E=McAfee;i="6800,10657,11847"; a="72223479" X-IronPort-AV: E=Sophos;i="6.25,164,1779174000"; d="scan'208";a="72223479" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 14:56:25 -0700 X-CSE-ConnectionGUID: +wuyvbA9TQGVlkH5cElinA== X-CSE-MsgGUID: 7zMPcqLoQKCUqrKmOkj3+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,164,1779174000"; d="scan'208";a="251561223" Received: from aschende-mobl.amr.corp.intel.com (HELO [10.125.108.131]) ([10.125.108.131]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2026 14:56:23 -0700 Message-ID: Date: Tue, 14 Jul 2026 14:56:22 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] crypto: iaa - avoid counting fallback decompression bytes To: Vinicius Costa Gomes , Vinod Koul , Frank Li , Kristen Accardi , Herbert Xu , "David S. Miller" , Andrew Morton , Yosry Ahmed , Nhat Pham Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Giovanni Cabiddu References: <20260713-iaa-crypto-fixes-zswap-v1-0-65cac23c684d@intel.com> <20260713-iaa-crypto-fixes-zswap-v1-3-65cac23c684d@intel.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20260713-iaa-crypto-fixes-zswap-v1-3-65cac23c684d@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/13/26 9:10 PM, Vinicius Costa Gomes wrote: > From: Giovanni Cabiddu > > When decompression falls back to deflate-generic after an analytics > error, the request no longer completes through IAA. > > Move decompression byte accounting into the successful IAA completion > path in both the synchronous and asynchronous flows so decomp_bytes only > reflects bytes actually processed by IAA. > > Signed-off-by: Giovanni Cabiddu Missing Vinicius sign-off. Reviewed-by: Dave Jiang > --- > drivers/crypto/intel/iaa/iaa_crypto_main.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c > index fb154959c2aa..8f68b1478476 100644 > --- a/drivers/crypto/intel/iaa/iaa_crypto_main.c > +++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c > @@ -1084,15 +1084,17 @@ static void iaa_desc_complete(struct idxd_desc *idxd_desc, > } > } else { > ctx->req->dlen = idxd_desc->iax_completion->output_size; > + > + if (!ctx->compress) { > + update_total_decomp_bytes_in(ctx->req->slen); > + update_wq_decomp_bytes(iaa_wq->wq, ctx->req->slen); > + } > } > > /* Update stats */ > if (ctx->compress) { > update_total_comp_bytes_out(ctx->req->dlen); > update_wq_comp_bytes(iaa_wq->wq, ctx->req->dlen); > - } else { > - update_total_decomp_bytes_in(ctx->req->slen); > - update_wq_decomp_bytes(iaa_wq->wq, ctx->req->slen); > } > > if (ctx->compress && compression_ctx->verify_compress) { > @@ -1475,16 +1477,16 @@ static int iaa_decompress(struct crypto_tfm *tfm, struct acomp_req *req, > } > } else { > req->dlen = idxd_desc->iax_completion->output_size; > + > + /* Update stats */ > + update_total_decomp_bytes_in(slen); > + update_wq_decomp_bytes(wq, slen); > } > > *dlen = req->dlen; > > if (!ctx->async_mode) > idxd_free_desc(wq, idxd_desc); > - > - /* Update stats */ > - update_total_decomp_bytes_in(slen); > - update_wq_decomp_bytes(wq, slen); > out: > return ret; > err: >