mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nuno Das Neves <nunodasneves@linux.microsoft.com>
To: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>,
	kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	decui@microsoft.com
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] Drivers: hv: Resolve ambiguity in hypervisor version log
Date: Fri, 10 Oct 2025 15:49:17 -0700	[thread overview]
Message-ID: <fa14e8f8-fe92-4636-9565-a6174edcea71@linux.microsoft.com> (raw)
In-Reply-To: <175996340003.108050.17652201410306711595.stgit@skinsburskii-cloud-desktop.internal.cloudapp.net>

On 10/8/2025 3:43 PM, Stanislav Kinsburskii wrote:
> Update the log message in hv_common_init to explicitly state that the
> reported version is for the Microsoft Hypervisor, not the host OS.
> 
> Previously, this message was accurate for guests running on Windows
> hosts, where the host and hypervisor versions matched. With support for
> Linux hosts running the Hyper-V hypervisor, the host OS and hypervisor
> versions may differ.
> 
> This change avoids confusion by making it clear that the version refers to
> the Microsoft Hypervisor regardless of the host operating system.
> 
> Signed-off-by: Stanislav Kinsburskii <skinsburskii@linux.microsoft.com>
> ---
>  drivers/hv/hv_common.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> index e109a620c83fc..0289ee4ed5ebf 100644
> --- a/drivers/hv/hv_common.c
> +++ b/drivers/hv/hv_common.c
> @@ -315,9 +315,9 @@ int __init hv_common_init(void)
>  	int i;
>  	union hv_hypervisor_version_info version;
>  
> -	/* Get information about the Hyper-V host version */
> +	/* Get information about the Microsoft Hypervisor version */
>  	if (!hv_get_hypervisor_version(&version))
> -		pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
> +		pr_info("Hyper-V: Hypervisor Build %d.%d.%d.%d-%d-%d\n",
>  			version.major_version, version.minor_version,
>  			version.build_number, version.service_number,
>  			version.service_pack, version.service_branch);
> 
> 

Looks like a good idea.

Reviewed-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>

  reply	other threads:[~2025-10-10 22:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 22:43 Stanislav Kinsburskii
2025-10-10 22:49 ` Nuno Das Neves [this message]
2025-10-31 18:32   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa14e8f8-fe92-4636-9565-a6174edcea71@linux.microsoft.com \
    --to=nunodasneves@linux.microsoft.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skinsburskii@linux.microsoft.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®