From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 730E047D932 for ; Wed, 3 Jun 2026 13:40:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780494050; cv=none; b=VBQ4W9/SIqTFADhVXEVaZ0aNRi1G6wOVH+9od1iwpqWGm+cqG2wXsS7zqZhDPocjfJ2HneU4H/icbh8yS4pA7VVJicqQ6JbY7zy272vedgXN2dbd8ZRSvOiDS7sunRV7BStlrfGpRfkPD3qwGI4khzeoHG7GjJ8+TPF+Sk83wps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780494050; c=relaxed/simple; bh=krjUmtyITYIPUcrxOM06VJgMAKrc3z7+A0NJ7PHRags=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hSPZprQWbuvTSsOHwOBW924odu6wQkZtgTgj87hl9vsi7n41a+DyFSE0HfsHWyS8TCe/+yO9q7ZpyM5AmWAAW6EGHbgDpR8a3Ru+oxAiSyiKEKfl3JbEE4AHKym6X8rn2J8Gq0YV+qcLonepsBZw0QwflGbveYWIck934jj6T2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QBclwb3x; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QBclwb3x" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490b09e4cccso17789975e9.0 for ; Wed, 03 Jun 2026 06:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780494048; x=1781098848; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=drDl7Um75iT8WkjafTauQmyYiz65cUc3KqncS4NQ1aY=; b=QBclwb3xrFknM1Co2Jo5ZFS9ohr27CfFPPBu7IQRuZrADyclM9dJ1570t695CpvUra AY1eKpmUNXiu5DOirC8Mn1wRZD2zwAycY1yNg1HLjmhcxFVEZ0DdI2AejOatLGLxamwh FIbRM5CXrBNaTkG2A75kYdFL6BZClF78tip+lJ5vvcZ+tDQMLxg2W7uk8AHJB+XbyK99 Yeys6EBeq67nj2KKtHKu6AXYwwYDlXIZsBh2bW89A1aALLDpVOWUARNjrWyHfiw1guyX n2Tx1GWCqZmgXcjCwKbkFKNSwRZvMbaLwBDOQ/BAwOzbM9aWGLxlUpHbkTJaOdXkenTN VLGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780494048; x=1781098848; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=drDl7Um75iT8WkjafTauQmyYiz65cUc3KqncS4NQ1aY=; b=UyOS/g7Uao0Svap3rOWx8qgb6KEheSafUTrsog8ytF0iZ3f25IbU5eXNCQ7AEQnnGB s+aMD9lwcRh9GR2ksVyiebz9qD2JRH8chfRe8pIXB+puSQAFfbgDw/pFTcKRJbMIX21q TAQ9BKky7ahNtrvPYrqnKrKJMlAGfh+2utD9FNrp5SnUHXpMmM2/YKwtbFOo6NiHrQzY W2ImkC15eod0q1B30Hs3/tF0wy5bgtknr3XzvmsA5QOzOKTjY1QtkhE3q8zrwGraQzrT xlhapvAxGzwxRTzaqxREcSJtC+zXaEBVDSrT/H51W+1+cFLwNAjJDDPIwDmiSkp699Ly 5jbA== X-Forwarded-Encrypted: i=1; AFNElJ8tUuem0ZnnjJl0L6uNeBLleDz7FjOo2Bh0RdGmSJ3nYSj6ZsuZ4S7P38N+go7AA7DyIl5ON+N3AdzKGBc=@vger.kernel.org X-Gm-Message-State: AOJu0YxooonkIZco0k6T166kqbO8XnlMezcqh/Rdmr8nogIfnVgtuAgm Tscr3e9q/D6VeYWSWHqDWUrtm1RAY0KS9RE+6V4wD7je+272Z/G5utdl X-Gm-Gg: Acq92OGY+VuKGxENI5yJokvHts3EckStcKFvITNZn/U+cVvP052K7+THsuWr5eDP0EE Zrhe+ZFuBKFcM5t7aXgsK5xSeB5uFwi2utp48dqaUWwxkW18HNTHtl+0uxCliSyF2PSRYgWWW5p GhBf9psN1DSCZKEzl8umTRsawPeXfzzf1UwBziHVFgVYvoPqVNA78s5gSeh9Ho+bx4k5q4j5n51 0gfywhfG11zdeCmnfuNAN+dQWT4OG037hCKv7KH/VhtlhqgJwWAsX4GLPDanYRqyl23I7cM5KyY Xeh3vkP2B/w0ouqStIEdvqC/JJErnlpialKD/L3f/O1KJAo/uo03moc3RxeGItrzWDMWU+BBp+e 3DasyAzbhYPAh05WZntv2lmZEZYcF8ou6hLPxdSRKZ1bTMY0IwgT+CHzwhsiQbI/vJC7yB5l7xZ kEkrgQxxMQWR3LIAFUhmUCwQJu+i80OcEFyNvBWMcnJQ== X-Received: by 2002:a05:600c:458b:b0:48f:e249:4094 with SMTP id 5b1f17b1804b1-490b5fe0adamr60241125e9.18.1780494047760; Wed, 03 Jun 2026 06:40:47 -0700 (PDT) Received: from [192.168.1.50] ([81.196.40.241]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b0e7639csm143868165e9.10.2026.06.03.06.40.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2026 06:40:47 -0700 (PDT) Message-ID: Date: Wed, 3 Jun 2026 16:40:45 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 0/2] staging: rtl8723bs: Fix error handling in _rtw_pktfile_read() To: Andy Shevchenko Cc: Minu Jin , gregkh@linuxfoundation.org, dan.carpenter@linaro.org, abrahamadekunle50@gmail.com, zxcv2569763104@gmail.com, milospuric856@gmail.com, karanja99erick@gmail.com, weibu@redadmin.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260127153811.1592900-1-s9430939@naver.com> Content-Language: en-US From: Bitterblue Smith In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/06/2026 03:48, Andy Shevchenko wrote: > On Sun, May 24, 2026 at 09:30:01PM +0300, Bitterblue Smith wrote: >> On 27/01/2026 17:38, Minu Jin wrote: >>> This series improves error handling in _rtw_pktfile_read() and cleans up >>> the code style to comply with kernel standards. >>> >>> 1. The first patch combines the logic change and caller updates. >>> The function change and the caller updates must be in the same >>> patch. If they are separated, the code will not work correctly >>> or will cause errors at that specific point in the history. >>> >>> 2. The second patch focuses purely on code style cleanup (changing uint >>> to unsigned int) as requested by Andy Shevchenko. >>> >>> Regarding the logic change in _rtw_pktfile_read(): >>> >>> The original code used a ternary operator to read whatever data was >>> available, even if it was less than requested. This could lead to >>> callers processing incomplete data without knowing it. >>> >>> I have changed this to return -EINVAL when the remaining data is insufficient. >>> This is safer because most callers expect the exact amount of data and >>> should not proceed with a partial read. >>> >>> Testing and Verification: >>> >>> I do not have access to the physical RTL8723BS hardware. However, I have >>> performed a rigorous manual audit of the data path and verified the >>> changes using Smatch static analysis. The analysis confirmed that no >>> new warnings or logical regressions were introduced in the modified files. >> >> I have some bad news: >> >> https://bbs.archlinux.org/viewtopic.php?id=313401 > > It's unclear that this patch made it happen. See below. > It looks pretty clear to me, but okay. I forwarded your request for bisection. >> [quote] >> >> Hey everyone, >> >> I recently upgraded my system, and now I’m having a strange issue with my >> WiFi (Realtek RTL8723BS). >> >> now I can no longer connect to any WiFi networks as a client. however, >> creating an Access Point (AP) still works fine, but whenever I try to connect >> to an existing network, the connection fails. >> >> dmesg logs: >> Every time I attempt a connection, dmesg gets spammed with this error: >> >> [ 1083.925640] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 >> [ 1084.921217] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 >> [ 1085.921434] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 >> [ 1086.922320] rtl8723bs mmc0:0001:1 wlan0: xmit_xmitframes: coalesce failed with error -22 >> .... >> >> Has anyone encountered this specific "coalesce" error with the rtl8723bs >> driver? I'm looking for advice on whether this is a known bug in recent >> kernels or if there's a specific module parameter I should try to bypass >> this. >> >> System Info: >> >> Chipset: RTL8723BS (SDIO) >> >> Kernel version: 7.0.3-zen1-2-zen >> >> update: I fixed the issue after kernel downgrade >> >> [/quote] > > That guy should bisect and find the culprit. It will help a lot to understand > what's going on. >