From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: mikhail.kshevetskiy@iopsys.eu, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 1/2] mtd: spinand: winbond: fix winbond lashes identifications
Date: Mon, 10 Oct 2022 09:11:34 +0200 [thread overview]
Message-ID: <fa1a74cb-d240-d3d1-1ede-3c786becef7d@kontron.de> (raw)
In-Reply-To: <20221007104820.198938-1-mikhail.kshevetskiy@iopsys.eu>
On 07.10.22 12:48, mikhail.kshevetskiy@iopsys.eu wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
^ identification
> is identified as W25N01GV (id_bytes: EF, AA, 21).
>
> Fix this by adding missed identification bytes.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Two things:
* each time you send a new version of your patches, you should increase
the version number in the prefix (e. g. using "git format-patch -v 2").
* I'm not a native English speaker and I don't get what "fix winbond
lashes identifications" is supposed to mean. Maybe something simple like
"fix identification" or "add missing id bytes" would do?
next prev parent reply other threads:[~2022-10-10 7:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 10:48 mikhail.kshevetskiy
2022-10-07 10:48 ` [PATCH 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support mikhail.kshevetskiy
2022-10-10 7:13 ` Frieder Schrempf
2022-10-10 7:11 ` Frieder Schrempf [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-07 10:40 [PATCH 1/2] mtd: spinand: winbond: fix winbond lashes identifications mikhail.kshevetskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1a74cb-d240-d3d1-1ede-3c786becef7d@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®