From: Philipp Stanner <phasta@mailbox.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Philipp Stanner <phasta@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Tamir Duberstein" <tamird@gmail.com>,
"Christian Schrefl" <chrisi.schrefl@gmail.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v4] rust: list: Add unsafe for container_of
Date: Mon, 23 Feb 2026 08:33:55 +0100 [thread overview]
Message-ID: <fa1c81f58b05faccf69dce8645a337f7bd35a9f7.camel@mailbox.org> (raw)
In-Reply-To: <CANiq72kgsgSW5tPj3xA0DLhJS8yBS_uDT=xDbNE=rf8t-H8Qzw@mail.gmail.com>
On Fri, 2026-02-20 at 02:08 +0100, Miguel Ojeda wrote:
> On Mon, Feb 16, 2026 at 2:17 PM Philipp Stanner <phasta@kernel.org> wrote:
> >
> > Add unsafe blocks to container_of to fix the issue.
>
> So I don't think this was tested with `CLIPPY=1`, because there are
> other safety comments missing even after this is applied.
>
> Please note that `CLIPPY=1` must remain clean for all Rust code:
>
> https://rust-for-linux.com/contributing#submit-checklist-addendum
>
> I have pushed to `rust-fixes` the patch with placeholders to show what
> is missing.
>
> I am not sure if I will keep it there.
>
Feel free to drop it for now, I can go through it properly with the
list author to see what the most accurate formulation would be.
next prev parent reply other threads:[~2026-02-23 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 13:16 Philipp Stanner
2026-02-19 18:21 ` Miguel Ojeda
2026-02-20 1:08 ` Miguel Ojeda
2026-02-23 7:33 ` Philipp Stanner [this message]
2026-02-23 17:46 ` Miguel Ojeda
2026-02-23 17:48 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1c81f58b05faccf69dce8645a337f7bd35a9f7.camel@mailbox.org \
--to=phasta@mailbox.org \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=chrisi.schrefl@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=phasta@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tamird@gmail.com \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®