From: Andrew Lunn <andrew@lunn.ch>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, u.kleine-koenig@baylibre.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next v3] net: ftgmac100: refactor getting phy device handle
Date: Thu, 24 Oct 2024 21:42:01 +0200 [thread overview]
Message-ID: <fa1ff3ab-b5c0-4efb-9fd4-81815ba4dd2b@lunn.ch> (raw)
In-Reply-To: <20241022084214.1261174-1-jacky_chou@aspeedtech.com>
On Tue, Oct 22, 2024 at 04:42:14PM +0800, Jacky Chou wrote:
> Consolidate the handling of dedicated PHY and fixed-link phy by taking
> advantage of logic in of_phy_get_and_connect() which handles both of
> these cases, rather than open coding the same logic in ftgmac100_probe().
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> v2:
> - enable mac asym pause support for fixed-link PHY
> - remove fixes information
> v3:
> - Adjust the commit message
It takes a bit of effort to see it is correct, but it looks O.K. to
me.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-10-24 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 8:42 Jacky Chou
2024-10-24 8:57 ` Simon Horman
2024-10-24 19:42 ` Andrew Lunn [this message]
2024-10-29 22:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1ff3ab-b5c0-4efb-9fd4-81815ba4dd2b@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacky_chou@aspeedtech.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®