From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A42C4363D for ; Thu, 24 Sep 2020 15:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F059C206CD for ; Thu, 24 Sep 2020 15:20:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="xjIa4C5k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728379AbgIXPUw (ORCPT ); Thu, 24 Sep 2020 11:20:52 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:44374 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728294AbgIXPUv (ORCPT ); Thu, 24 Sep 2020 11:20:51 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08OFKbmD053626; Thu, 24 Sep 2020 10:20:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600960837; bh=As0LBQrlo7GbhKXw66VgAuUH9w1aj9X87IwzCpW+vT4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=xjIa4C5kIQgkKD1o5cTbyDD+vxUvBx6vLaaIGcyQ6gTYb5XP3wCA/WEvZ0GIxuVuT rixW574qS4cClFNGK9UbcbGgj/Kwv3nhtMGNYB3cQNPLZXFG6QdifxMBRW4cRNGA/8 sacQw/Pua6Fru4oym/MkROOvGSAEtuomvOCL62QI= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08OFKbDt054494 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 24 Sep 2020 10:20:37 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 24 Sep 2020 10:20:37 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 24 Sep 2020 10:20:37 -0500 Received: from [10.24.69.198] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08OFKYtn005534; Thu, 24 Sep 2020 10:20:35 -0500 Subject: Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL To: Necip Fazil Yildiran CC: , , , , , References: <20200914123848.307406-1-fazilyildiran@gmail.com> From: Sekhar Nori Message-ID: Date: Thu, 24 Sep 2020 20:50:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200914123848.307406-1-fazilyildiran@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Necip, On 14/09/20 6:08 PM, Necip Fazil Yildiran wrote: > When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results > in the following Kbuild warning: > > WARNING: unmet direct dependencies detected for PINCTRL_SINGLE > Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y] > Selected by [y]: > - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y] > > The reason is that ARCH_DAVINCI selects PINCTRL_SINGLE without depending on > or selecting PINCTRL while PINCTRL_SINGLE is subordinate to PINCTRL. > > Honor the kconfig menu hierarchy to remove kconfig dependency warnings. > > Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5") > Signed-off-by: Necip Fazil Yildiran I think its better to fix this by changing the "select PINCTRL_SINGLE" to "imply PINCTRL_SINGLE". It should be valid to build a DaVinci kernel without pinctrl support if bootloader is taking care of the pin muxing. I would not recommend it, but its not illegal either. While at it, I would drop the other "select PINCTRL" line under "config MACH_DA8XX_DT". It should not be needed since ARCH_DAVINCI will imply PINCTRL_SINGLE Thanks, Sekhar