Re: [PATCH v4 06/10] media: Add C3ISP_PARAMS and C3ISP_STATS meta formats

[Keke Li <keke.li@amlogic.com>]

Hi Jacopo

Thanks very much for your reply.

On 2024/12/12 00:04, Jacopo Mondi wrote:
> [ EXTERNAL EMAIL ]
>
> Hi Keke
>
> On Thu, Dec 05, 2024 at 05:04:32PM +0800, Keke Li via B4 Relay wrote:
>> From: Keke Li <keke.li@amlogic.com>
>>
>> C3ISP_PARAMS is the C3 ISP Parameters format.
>> C3ISP_STATS is the C3 ISP Statistics format.
>>
>> Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
>> Signed-off-by: Keke Li <keke.li@amlogic.com>
>> ---
>>   drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++
>>   include/uapi/linux/videodev2.h       | 4 ++++
>>   2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
>> index 0304daa8471d..dae34b1170d7 100644
>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c
>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c
>> @@ -1460,6 +1460,8 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
>>        case V4L2_META_FMT_RK_ISP1_PARAMS:      descr = "Rockchip ISP1 3A Parameters"; break;
>>        case V4L2_META_FMT_RK_ISP1_STAT_3A:     descr = "Rockchip ISP1 3A Statistics"; break;
>>        case V4L2_META_FMT_RK_ISP1_EXT_PARAMS:  descr = "Rockchip ISP1 Ext 3A Params"; break;
>> +     case V4L2_META_FMT_C3ISP_PARAMS:        descr = "Amlogic C3 ISP Parameters"; break;
>> +     case V4L2_META_FMT_C3ISP_STATS:         descr = "Amlogic C3 ISP Statistics"; break;
>>        case V4L2_PIX_FMT_NV12_8L128:   descr = "NV12 (8x128 Linear)"; break;
>>        case V4L2_PIX_FMT_NV12M_8L128:  descr = "NV12M (8x128 Linear)"; break;
>>        case V4L2_PIX_FMT_NV12_10BE_8L128:      descr = "10-bit NV12 (8x128 Linear, BE)"; break;
>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>> index e7c4dce39007..eda30640a7a3 100644
>> --- a/include/uapi/linux/videodev2.h
>> +++ b/include/uapi/linux/videodev2.h
>> @@ -858,6 +858,10 @@ struct v4l2_pix_format {
>>   #define V4L2_META_FMT_RK_ISP1_STAT_3A        v4l2_fourcc('R', 'K', '1', 'S') /* Rockchip ISP1 3A Statistics */
>>   #define V4L2_META_FMT_RK_ISP1_EXT_PARAMS     v4l2_fourcc('R', 'K', '1', 'E') /* Rockchip ISP1 3a Extensible Parameters */
>>
>> +/* Vendor specific - used for C3_ISP */
>> +#define V4L2_META_FMT_C3ISP_PARAMS   v4l2_fourcc('C', 'P', 'R', 'M') /* Amlogic C3 ISP Parameters */
>> +#define V4L2_META_FMT_C3ISP_STATS    v4l2_fourcc('C', 'S', 'T', 'S') /* Amlogic C3 ISP Statistics */
> I would have used ('C', '3', 'P', 'M') and ('C', '3', 'S', 'T').
> Matter of tastes I guess, but if you will happen to have a different
> format for, say, C7, this would help keeping them separate.


Will use ('C', '3', 'P', 'M') and ('C', '3', 'S', 'T').

>
> Up to you
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
> Thanks
>    j
>
>> +
>>   /* Vendor specific - used for RaspberryPi PiSP */
>>   #define V4L2_META_FMT_RPI_BE_CFG     v4l2_fourcc('R', 'P', 'B', 'C') /* PiSP BE configuration */
>>   #define V4L2_META_FMT_RPI_FE_CFG     v4l2_fourcc('R', 'P', 'F', 'C') /* PiSP FE configuration */
>>
>> --
>> 2.47.0
>>
>>
>>