From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060D93C3C0E for ; Tue, 26 May 2026 07:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779782026; cv=none; b=LwP9/fh1DDwi/gp2D446vT1NPVN3eW4ESJ6SsH1t90u5m9FNGyZ0MaNu6OOt/4QpVd3nEgZ6xb8/qF0ji3CPFIxWyLuW7KXDdm5ng77I8su5ly2YIURwvyftmej7mCF05sl5hDm0NS2Yn/Xl1KYiEzmedZw5TY4dzqVQQlAkbJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779782026; c=relaxed/simple; bh=FQItYE5lhOgysObmk/9s1tt32WG7yWkaKTC+0wxlmaQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gc6HyjwW05i0/1qUXCbgIYU/k241GV7BCFOxHr1lbLObBCc2poU+ZT8bd9KYTrPHuEIoBIR7JgfMS/rmln+I4ptVgu64AEI1KT8R7quV464AkCgpXnq+p1epkDR9rOI7CWGNkiDg25Yl26aJ7565z1A4R47ohCJY2uZF5YwftMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nsyg1ER3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VRXpxD/P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nsyg1ER3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VRXpxD/P" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64Q6af5V3263566 for ; Tue, 26 May 2026 07:53:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OuL8yKBdugShDKTmzUjZs0KnNoPZVA0o6dUNMSnFCgQ=; b=nsyg1ER3Mn1HiMIs tGfFWi4/CKUC/lVPWG6EF/pdLEXCxmskLy4FCCMNi4/gmKME+wZB7J/28q6BmWQR 6vCbd9HGPvlUAHHF0FKh1OvjEZ80v5erbm7qlIimv0pOa2wNiRsMNYA1hPJeJDAn S5YFDnAjGspA5whZlVxvo8fjXwwvtgd+Mkx1TSy3WDkKYfG0hgjHuK3B65o4HPEx 7RrF3ntJxS8J20sOsnFXOlyt+G75tENULnxj05REOkj9CbTR7Ku/eDNVLr+DSRej qs6mrxmpae6XXt8GPhqxU+r0jgApmzOql5rSyknK8FFKeQfjQSJqTJH4bMbC0gLj mPS6SQ== Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ecnhs39ku-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 07:53:43 +0000 (GMT) Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-1353a6f29deso6860458c88.1 for ; Tue, 26 May 2026 00:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779782023; x=1780386823; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OuL8yKBdugShDKTmzUjZs0KnNoPZVA0o6dUNMSnFCgQ=; b=VRXpxD/PVQhTwBnRff5qBWaQTu5QupZXPMGqyjLR7IxBKVO1uTYcSEqY0hAfy7Wwep aUAHw828l5XbipvNNWNkZtEtCD6ETJhHxAQyi19JVysjcsrmVyQ4zUeIqHlGVocHa12Y 3FER3lW8r3So1oypLGT8oL7AUA0j/5un8eoUH70QyPzeHkHICwOmBeOvU7k4IOTvbSf7 2R/pKc1u9+W869qTLPoWsQAto5K6cS3kl7JPNWX2Iv/05us0kb6VwD8CTXNmmjnJnh5+ ISHPTkZmHER74un5tc/dn0cfEdmVm+cPisuVM+zh+/QJWBtYED5x4Essus7sI91SutYm 7hWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779782023; x=1780386823; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OuL8yKBdugShDKTmzUjZs0KnNoPZVA0o6dUNMSnFCgQ=; b=BknWfkn0tjLDDav54qDVbeXnkvTzwN72UT78Qih7bYU0jwdRs41pGy35/jkXzkG0Fy nKHkGOTZXl7KuVEmRf5vzxHJXIiwB/A2YXkkLNPhJAnOd1/tMK2hyWuWqz8n5Aw+3TNX lMsQE+2UnXzaHHTF9bsKqb+yVPs0Ee+ZFCdjNCpPVhrMnS2v8T+D5BaGHvW5ytJNiaoY unZ9IWSbwVDsAYQ58HcyI1Oz2w5qkk1XLgmcjiCD9nvzf327P+FQ1zgtkNkthVrKOZnR 7khzHKfeixR6PNH2rFWHwovSoJ1ndUtPcmNOJYPwX46NQeGS5Qpi5vRYf4/aRHDo7JMu QiUA== X-Forwarded-Encrypted: i=1; AFNElJ+x4MvqNN8gHhIWlOlbjc4I9aRPn3Jn5OMrk711mPfP0R8qEVgIkWPpq5jq16wU3GZwoU0E8KNqRXgZsI0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa4xNFjG3qkfbGa2rtliKV33xTeuAjUZ/h7+Jua78SCThseITC 99enHWyUc3o/tDzp32/7X1fkRjkJ756zwwySm2pZFMT6BV1my9WB5weuHcrWpkTK8nZx8u+W3lg GyHDWamyiGQycdB4H5lWTol5P7EYrVAuUNifDCzLe6Uhd7VfzQOkKvlxRf13t7azGWVY= X-Gm-Gg: Acq92OFnhg4CXxWLnsOJi2J+o4U+X2uaztXb/qFpldF0juT4HDWK2d0+Tgromu9vugC CcNY6SiedgZXn4J+rjxH7L6VeqwUxRQ11BiQm7YleE4fUvQqOrcJmf0cIEfaPm9LjiMZQNIxdWY wbqyileVpY12+zwmNbee2g9d4diigv/SoQVgCeEcTPW3AHx+erVxXPbfIXCCknHYPCJcNW2B3ju MPWHP3WFATpwhuoZGITuDT90/rteO4qS+X09AyqTojh40h2JDMNFTh/GbGdilno8gHeVElzTB7F hFEy39m7scP/7LEIX7ZTYbOi/h2TJwfXD4VOZ+1raV0hkhQoA4g8a1uKjp9JuReSGxggmZQ/C1D emsiw56L2GKmHYE9ApWaOLpehv688p9c0LTGxYaA21BoceJ017FgR X-Received: by 2002:a05:7301:d0f:b0:2ed:e15:c923 with SMTP id 5a478bee46e88-30449142740mr7787210eec.31.1779782022799; Tue, 26 May 2026 00:53:42 -0700 (PDT) X-Received: by 2002:a05:7301:d0f:b0:2ed:e15:c923 with SMTP id 5a478bee46e88-30449142740mr7787195eec.31.1779782022220; Tue, 26 May 2026 00:53:42 -0700 (PDT) Received: from [10.68.116.254] ([146.0.26.16]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30451f1fd1csm9838346eec.8.2026.05.26.00.53.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 00:53:41 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 13:23:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/6] media: qcom: iris: add support for decoding 10bit formats To: Neil Armstrong , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov , Bryan O'Donoghue References: <20260521-topic-sm8x50-iris-10bit-decoding-v4-0-8ff8fce3f904@linaro.org> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260521-topic-sm8x50-iris-10bit-decoding-v4-0-8ff8fce3f904@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vd3H+lp9 c=1 sm=1 tr=0 ts=6a155187 cx=c_pps a=SvEPeNj+VMjHSW//kvnxuw==:117 a=3xFAF2x3o65iZn5cP+8M2w==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=e5mUnYsNAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=bC-a23v3AAAA:8 a=KKAkSRfTAAAA:8 a=PPvw34hF8QDUbFAgV6MA:9 a=QEXdDO2ut3YA:10 a=Kq8ClHjjuc5pcCNDwlU0:22 a=Vxmtnl_E_bksehYqCbjh:22 a=FO4_E8m0qiDe52t0p3_H:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: IMV9SUvzoxo_PTor-kaOS7aAjhjlfOp- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA2OCBTYWx0ZWRfX6zBbQVY2DdRI C/4mNWRx4ijPy24IFvX/mfbq16Q0wkxAL6mbQDEB+Fvzvtp1msCNY0xufwyulWK4SjOb2qyM3iS a3NlAHDD1RhYiLiGR+EVLbWw+IIhcN6AfWG2Vkjw2RCM24NTPuxCjUivp9aKzvE1zk/UBqV+w50 0B3OqXHQ3X2xNF7QjRMocN9/ITW5DkdOq44DEmOZekYc7pIHOkkbchKXtkMopdL+rgGQHvRSCIl dGHByNLyhq3wglJM9iGX3XUtKwjLcMxoRgPNBLY/6pQ5JiG+almx4PKMhSpGqSoTKbsTt7HTetD HKxcTqEusC4cYpXH288ma5DEDKNOd7wDg7Cv92fjItzNv4S5bjjYABnGzgcNVSgCjJh3d7sQARY DYEGLTfv+guMmgy4NnyE+fGNF0YcCqwt22PbNIBxjeJIk0WFkHKHeGSoJVFAVBzK/WaH+8rQmQ4 jhe+VojsVlf/aYZGTDA== X-Proofpoint-ORIG-GUID: IMV9SUvzoxo_PTor-kaOS7aAjhjlfOp- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-26_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260068 On 5/21/2026 2:54 PM, Neil Armstrong wrote: > This adds the plumbing to support decoding HEVC, VP9 and AV1 > streams into 10bit pixel formats, linear and compressed. > > This has only been tested on SM8550 & SM8650 with HEVC, and was > inspired by Venus, DRM MSM and the downstream vidc driver for the > buffer calculations and HFI messages. > > Gstreamer support for QC08 and QC10 need the MR at [1] to be applied, > but NV12 and P010 works out of the box with mainline Gstreamer. > > Fluster HEVC results on SM8650 using Gstreamer: > > ./fluster.py run -ts JCT-VC-HEVC_V1 -d GStreamer-H.265-V4L2-Gst1.0 - 141/147 > The failing test case: > - Pixel Format mismatch > - TSUNEQBD_A_MAIN10_Technicolor_2 - Gstreamer waits NV12 but decoder returns P010 > - Unsupported resolution > - PICSIZE_A_Bossen_1 - resolution is higher than max supported > - PICSIZE_B_Bossen_1 - resolution is higher than max supported > - WPP_D_ericsson_MAIN_2 - resolution is lower than min supported > - WPP_D_ericsson_MAIN10_2 - resolution is lower than min supported > - CRC mismatch > - RAP_A_docomo_6 > > > Total for iris_driver device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 0 > > [1] https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8195 > > Signed-off-by: Neil Armstrong > --- > Changes in v4: > - Picked review tags > - Use u32 instead of __u32 > - Explicit DPB > - Drop NULL and use >>1 in q10c buffer calc > - Drop selicolon after switch statementr > - Correctly align HFI_PROP_UBWC_STRIDE_SCANLINE entry Its not very clear. Does this fix the issue reported here [1] ? https://lore.kernel.org/linux-media/fb377b11-c54c-4bd9-bf12-cf19d6484c66@oss.qualcomm.com/ > - Rebase on media next tree after the file split > - Link to v3: https://patch.msgid.link/20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org > > Changes in v3: > - Added review tag on patch 1 > - Limited stride command to AV1 decoding only > - Link to v2: https://patch.msgid.link/20260417-topic-sm8x50-iris-10bit-decoding-v2-0-c987b65a31d5@linaro.org > > Changes in v2: > - Fixed bug breaking 8bit decoding > - Dropped filtering on G_FMT while waiting for soure change > - Dropped format filtering on ENUMFMT > - Switched ALIGN(x, 192) to roundup(x, 192) because ALIGN works only with Power Of Two numbers > - Cleaned and refactors the width/height/stride calculations > - Cleaned and redesigned the buffer calculations functions with proper comments and var names > - Passed fluster and v4l2-compliance to check for non regression > - Tested on SM8550 > - Added missing V4L2_MPEG_VIDEO_HEVC_PROFILE_MAIN_10 with made gstreamer fail decoding > - Link to v1: https://patch.msgid.link/20260408-topic-sm8x50-iris-10bit-decoding-v1-0-428c1ec2e3f3@linaro.org > > --- > Neil Armstrong (6): > media: qcom: iris: add helpers for 8bit and 10bit formats > media: qcom: iris: add QC10C & P010 buffer size calculations > media: qcom: iris: gen2: add support for 10bit decoding > media: qcom: iris: vdec: update size and stride calculations for 10bit formats > media: qcom: iris: vdec: update find_format to handle 8bit and 10bit formats > media: qcom: iris: vdec: allow GEN2 decoding into 10bit format > > drivers/media/platform/qcom/iris/iris_buffer.c | 195 ++++++++++++++++++++- > drivers/media/platform/qcom/iris/iris_hfi_gen2.c | 8 +- > .../platform/qcom/iris/iris_hfi_gen2_command.c | 75 +++++++- > .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 + > .../platform/qcom/iris/iris_hfi_gen2_response.c | 37 +++- > drivers/media/platform/qcom/iris/iris_instance.h | 2 + > .../platform/qcom/iris/iris_platform_common.h | 1 + > drivers/media/platform/qcom/iris/iris_utils.c | 16 +- > drivers/media/platform/qcom/iris/iris_utils.h | 2 + > drivers/media/platform/qcom/iris/iris_vdec.c | 42 ++++- > 10 files changed, 364 insertions(+), 15 deletions(-) > --- > base-commit: 86693e86019a7466be961fd4f45d407cc0b0ba0a > change-id: 20260408-topic-sm8x50-iris-10bit-decoding-074c3ac7975c > > Best regards, > -- > Neil Armstrong > Regards, Vikash