From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC6CCC282DD for ; Tue, 23 Apr 2019 11:32:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93E9321738 for ; Tue, 23 Apr 2019 11:32:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727565AbfDWLco (ORCPT ); Tue, 23 Apr 2019 07:32:44 -0400 Received: from foss.arm.com ([217.140.101.70]:54920 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726033AbfDWLco (ORCPT ); Tue, 23 Apr 2019 07:32:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 006D2A78; Tue, 23 Apr 2019 04:32:44 -0700 (PDT) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B98383F557; Tue, 23 Apr 2019 04:32:42 -0700 (PDT) Subject: Re: [RFC] arm64: swiotlb: cma_alloc error spew To: dann frazier , Christoph Hellwig Cc: Marek Szyprowski , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Xinwei Kong References: <20190417204817.GA28897@xps13.dannf> From: Robin Murphy Message-ID: Date: Tue, 23 Apr 2019 12:32:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417204817.GA28897@xps13.dannf> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/04/2019 21:48, dann frazier wrote: > hey, > I'm seeing an issue on a couple of arm64 systems[*] where they spew > ~10K "cma: cma_alloc: alloc failed" messages at boot. The errors are > non-fatal, and bumping up cma to a large enough size (~128M) gets rid > of them - but that seems suboptimal. Bisection shows that this started > after commit fafadcd16595 ("swiotlb: don't dip into swiotlb pool for > coherent allocations"). It looks like __dma_direct_alloc_pages() > is opportunistically using CMA memory but falls back to non-CMA if CMA > disabled or unavailable. I've demonstrated that this fallback is > indeed returning a valid pointer. So perhaps the issue is really just > the warning emission. The CMA area being full isn't necessarily an ignorable non-problem, since it means you won't be able to allocate the kind of large buffers for which CMA was intended. The question is, is it actually filling up with allocations that deserve to be there, or is this the same as I've seen on a log from a ThunderX2 system where it's getting exhausted by thousands upon thousands of trivial single page allocations? If it's the latter (CONFIG_CMA_DEBUG should help shed some light if necessary), then that does lean towards spending a bit more effort on this idea: https://lore.kernel.org/lkml/20190327080821.GB20336@lst.de/ Robin. > The following naive patch solves the problem for me - just silence the > cma errors, since it looks like a soft error. But is there a better > approach? > > [*] APM X-Gene & HiSilicon Hi1620 w/ SMMU disabled > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > index 6310ad01f915b..0324aa606c173 100644 > --- a/kernel/dma/direct.c > +++ b/kernel/dma/direct.c > @@ -112,7 +112,7 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > /* CMA can be used only in the context which permits sleeping */ > if (gfpflags_allow_blocking(gfp)) { > page = dma_alloc_from_contiguous(dev, count, page_order, > - gfp & __GFP_NOWARN); > + true); > if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > dma_release_from_contiguous(dev, page, count); > page = NULL; > > > >