From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC9F5C433EF for ; Wed, 25 May 2022 15:18:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245094AbiEYPSe (ORCPT ); Wed, 25 May 2022 11:18:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbiEYPSa (ORCPT ); Wed, 25 May 2022 11:18:30 -0400 Received: from relay3.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8838FAFAE9 for ; Wed, 25 May 2022 08:18:25 -0700 (PDT) Received: from omf01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 566E6121361; Wed, 25 May 2022 15:18:24 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf01.hostedemail.com (Postfix) with ESMTPA id 16C9360009; Wed, 25 May 2022 15:18:22 +0000 (UTC) Message-ID: Subject: Re: [PATCH] ext4: add KERN_ for printk() From: Joe Perches To: Yu Zhe , tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, liqiong@nfschina.com Date: Wed, 25 May 2022 08:18:22 -0700 In-Reply-To: <20220525124816.86915-1-yuzhe@nfschina.com> References: <20220525124816.86915-1-yuzhe@nfschina.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: ffimii8t86ekppstzgu1g7s9g4zcecuu X-Rspamd-Server: rspamout08 X-Rspamd-Queue-Id: 16C9360009 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/TmTIrRKHyXtZxBIwCQr8v2pNMTsaHpqI= X-HE-Tag: 1653491902-998717 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-05-25 at 05:48 -0700, Yu Zhe wrote: > printk() should include KERN_ facility level, add them. NACK. checkpatch is just a guide. You have to inspect the code to determine if what checkpatch emits should be followed or ignored. > diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c [] > @@ -628,7 +628,7 @@ static struct stats dx_show_leaf(struct inode *dir, > char *base = (char *) de; > struct dx_hash_info h = *hinfo; > > - printk("names: "); > + printk(KERN_WARNING "names: "); > while ((char *) de < base + size) > { > if (de->inode) > @@ -648,7 +648,7 @@ static struct stats dx_show_leaf(struct inode *dir, > /* Directory is not encrypted */ > ext4fs_dirhash(dir, de->name, > de->name_len, &h); > - printk("%*.s:(U)%x.%u ", len, > + printk(KERN_WARNING "%*.s:(U)%x.%u ", len, _might_ use KERN_CONT, > name, h.hash, > (unsigned) ((char *) de > - base)); > @@ -683,7 +683,7 @@ static struct stats dx_show_leaf(struct inode *dir, > else > ext4fs_dirhash(dir, de->name, > de->name_len, &h); > - printk("%*.s:(E)%x.%u ", len, name, > + printk(KERN_WARNING "%*.s:(E)%x.%u ", len, name, and here, etc... [] > diff --git a/fs/ext4/super.c b/fs/ext4/super.c [] > @@ -941,9 +941,9 @@ void __ext4_msg(struct super_block *sb, > vaf.fmt = fmt; > vaf.va = &args; > if (sb) > - printk("%sEXT4-fs (%s): %pV\n", prefix, sb->s_id, &vaf); > + printk(KERN_WARNING "%sEXT4-fs (%s): %pV\n", prefix, sb->s_id, &vaf); You broke the logging here. Did you check what prefix is and how it is used in ext4_msg ? > else > - printk("%sEXT4-fs: %pV\n", prefix, &vaf); > + printk(KERN_WARNING "%sEXT4-fs: %pV\n", prefix, &vaf); > va_end(args); > } >