From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74CA3C3A5A7 for ; Tue, 6 Dec 2022 09:13:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233890AbiLFJNG (ORCPT ); Tue, 6 Dec 2022 04:13:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231220AbiLFJM5 (ORCPT ); Tue, 6 Dec 2022 04:12:57 -0500 Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7C47BC9F for ; Tue, 6 Dec 2022 01:12:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1670317976; x=1701853976; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4mt0j/vdtWfJcSSBLLsGjJ3hTgh4e+ZqWrii34fueUY=; b=fry072YNwg5T8o7D3PxwcpEEQthUrQOnxD04gBD1jNOpH9n5zJhUyNco 5XWLVVRwaN+rRU9X0EbQJQe/v323F2t0RloNSNKyZ5JHSJFYoGnMfU6g7 MPfFXuLTCjGnrOVrzdEZW8DKipAlyS63/u8OzQdOKUPZcXA5WzcllCmYk G69lBPlIOhq5i5KO0CK8juHIFGxZNerrkA+4+A1eSW6d/Nw6iCgp4cKGS PuYkN7utXSxohKvFJao1HSDGQpT9ExsU7N1Mo7494O4Xp2WVMuZxWygZg aZ+O1J1tGENjBVKa3OmCMxDa2Nx7Yp/U96GR3sHtCp4dp9CpULh656gFW Q==; X-IronPort-AV: E=Sophos;i="5.96,220,1665417600"; d="scan'208";a="217990543" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 06 Dec 2022 17:12:54 +0800 IronPort-SDR: 1aIBve8iRHszO/o7tn59kVff0Kh6jlwM9056JpuJ/TBqrwjpD+bj2Or47b1qZ1uXx2XGm0KJzD uD/CDAn/0ZYF5R/OG6se6wzLhjVXouD8JgqQafxI4rtmpBJ1OZnMsQ/SLzj7eIFzlEFO4hePOK pTWZ/TL+ZFLmi3c+UWPIHYIMUd4m3Z16KOF9b/eWVE5ve+xsDfglvDEe78rBj/pREAIHacwtuB 9paxQ7RLzOBCB+Lzy5ypdogUZggBL4YzoYMKq4lWL3KU2NODUD4kR+vRXSmn+BOqG5Vv6k00Sg Wqk= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Dec 2022 00:31:26 -0800 IronPort-SDR: b/Qq7WvwJHWKEtXMn4Gp//hhcH+p5GjPdiXI2OWmeftukdZk9IZO6/+wWar42S1nOq0Ps2vm0X 8/RELPaK9t2tZXPcTvkWbAs6uRrI30v6ynZALzN7kyH07bYJlV6isOeNqZUKsxRr9z7Ty/rOVA 4h7wt3OhR/BBY5Ujg6tSDfInueCDlMOvd9BZfbXTvEJCtnz7j2O3lvf/0U9GieYely8FvSY/Ql bxBAi62zZCTfsJQsXYjvrHhEr0GbkpDGOy5ljKQAsVRTxkLUKjGOysok7/NZCI7TR+LhlnTo/9 Vbw= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Dec 2022 01:12:55 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4NRF7T43gkz1Rwtl for ; Tue, 6 Dec 2022 01:12:53 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1670317972; x=1672909973; bh=4mt0j/vdtWfJcSSBLLsGjJ3hTgh4e+ZqWri i34fueUY=; b=YNSyUHBzaAuo3ULsinKsC2zO2BLGCy3UVeDKqHthvVvj2MyBt8d KEQA8yVLkKSd3gfSQAQb+PnVDFrHNJOPeOWDJTZnqxUSC+Ho0Ti2B+p1EvLvsL/N YTcAFyY8G5NhmSY53yzHQKnA7VFtc0lu/fSJpEVtfTWx5DDw/bF0bn3He25govb3 nsUWOBFCbvrWuB2DMh5kxLd8RuDY3UW9CQTp+uwXVKKZA10yT8vlvP5mtgB5qAM4 6jsBpQKjgFNZczbuGXW4p5vOYBipJ4SzaNettuVsPzfmMC8JZtXYdENAZWY6nrpp Fa3zaxB3wUKjUdIMUf6tSq6VWTIjmxUTasw== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MUsWinbuV4PX for ; Tue, 6 Dec 2022 01:12:52 -0800 (PST) Received: from [10.225.163.74] (unknown [10.225.163.74]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4NRF7Q0fHvz1RvLy; Tue, 6 Dec 2022 01:12:49 -0800 (PST) Message-ID: Date: Tue, 6 Dec 2022 18:12:48 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag Content-Language: en-US To: Serge Semin , Arnd Bergmann Cc: Anders Roxell , Niklas Cassel , Naresh Kamboju , Praneeth Bajjuri , Serge Semin , open list , Linux ARM , "regressions@lists.linux.dev" , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "lkft-triage@lists.linaro.org" , Lukas Bulwahn , Carlos Hernandez , Sumit Semwal References: <20221014140633.mlypet7skkxvt453@mobilestation> <20221017155246.zxal2cfehjgaajcu@mobilestation> <20221205011105.4do4trbytq4bfw5b@mobilestation> <98670e23-6553-4788-8662-9403c480af82@app.fastmail.com> <20221206084637.olaflvqmxwoo467a@mobilestation> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20221206084637.olaflvqmxwoo467a@mobilestation> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/6/22 17:46, Serge Semin wrote: > On Mon, Dec 05, 2022 at 10:24:22PM +0900, Damien Le Moal wrote: >> On 12/5/22 19:08, Arnd Bergmann wrote: >>> On Mon, Dec 5, 2022, at 02:11, Serge Semin wrote: >>>> On Thu, Dec 01, 2022 at 12:48:32PM +0100, Anders Roxell wrote: >>> >>>>> >>>>> for (i = 0; i < hpriv->n_clks; i++) { >>>>> - if (!strcmp(hpriv->clks[i].id, con_id)) >>>>> + if (hpriv->clks && hpriv->clks[i].id && >>>>> + !strcmp(hpriv->clks[i].id, con_id)) >>>>> return hpriv->clks[i].clk; >>>>> } >>>> >>>> Indeed I should have taken into account that devm_clk_bulk_get_all() >>>> can get unnamed clocks too. But checking the hpriv->clks pointer for >>>> being not null is redundant, since the ahci_platform_get_resources() >>>> procedure makes sure that the array is always allocated. At the very >>>> least you shouldn't check the pointer in the loop, but can make sure >>>> that the clks array is available before it. >>> > >>> Do you think this is otherwise the correct fix then? Any chance we >>> can still get a version of it into 6.1? > > I'll think of a better solution. But at this stage it seems like the > best choice seeing the bindings permit having unnamed clocks > specified. > >> >> If someone sends me a proper patch to apply, I can send a last PR for 6.1 >> to Linus before week end. > > I'll submit the patch today. Thanks. Anders just posted one. Can you review it please ? > > -Serge(y) > >> >> >>> >>> Arnd >> >> -- >> Damien Le Moal >> Western Digital Research >> -- Damien Le Moal Western Digital Research