From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46C3C3876CB for ; Thu, 29 Jan 2026 11:28:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769686104; cv=none; b=dXHjBj+zreaTaG+Ez/PFRQzrsdc9QDEhtDvNdN69DKjPFFDsWTnKMcYUzA8P/VaeAhfmDkS8Dj2hI1viDZDirCHOeNjoKC92ENoVkTs4Vzx6eTIIaiiHywdsBa0BXXiQytokrM9DwGJBTzxCLIU9EJ2HPM1yKcbsoyMlnreIgSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769686104; c=relaxed/simple; bh=p2axHXkBLcb/YxRj2QZU2q+JRuLkBNp+GmrjT0DWn04=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=acW7bJjGy62gck2vGDrjc1yrZmzb2uSGzANHMcch0XvxVPZiMPflOq41I43IDdMhUQq63/0npiXxUXkLNuf/FjNeUKpR78cJqJ7+/R8E2Mo0wm03gI4FoRSZkyMomlwfCQK/1xGHP8zOrK50kNOVL637XRL0aMVSuyXnIGm6LgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oyX+7pFv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HvTXAja/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oyX+7pFv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HvTXAja/" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TAR4DP2504059 for ; Thu, 29 Jan 2026 11:28:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= itAneaJJLEuJh0bM1d3ExjX/oEb9v6fnFKl3auDIGbw=; b=oyX+7pFveMY1swCg hF/HsGHcnzWK3j0JCEtgkTJYYW0wL6MVcm1ii09O5YfqjrbUyf54cZOFk3FTYl1+ +NrSICzMSzF1YowilAnRJuDSFg9Bq3cx7InPUXjbfC/e0Z/mpjgLiTXH4oM2zxDv VnDPTwsxrPbSMyA10HzNNxIoUAgJ38E0yScp/OPouzlmA2ovPUj9a11TJrRWNG3J aKrnfAE1KNUujLJXoFD/GdLP2+304SHeso/3q1xLsznW6L/AHZaX5HzLnWoi5mZY /TvYmc/VQ/CCODA0KPdGFr1LdPuovV6dg2MS9o54NGRNtumUUqcq7TAum/K886tJ aCvV8w== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c05tbr5he-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 11:28:21 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8946c23cf90so2987046d6.1 for ; Thu, 29 Jan 2026 03:28:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769686100; x=1770290900; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=itAneaJJLEuJh0bM1d3ExjX/oEb9v6fnFKl3auDIGbw=; b=HvTXAja/XcnzN5u52oaVFixJc5VdimtSMDi6t6HgW3sqYQBlGUYpXS5pK+524KZUUw o5Rf2qcyQUI1T7wJElnqLfoU/rKccsfAUFI50rnv3xqABeq6VLXTsDvyZxcfJeSBxiXB yMAkMBtCJxbiTG9i6MXaqYS6Zp54XhFG+VraBWuwMpOIqO/cnkZHow4HLa2kaiIFeIqI Xb2YoT2CtzPZXMIfTXgpHqTg4b0WX80QjilqfMPxMrk/SMBQR2/53Lr0J7BzwJ5CIm2V wnN+e8jRoresfA0guxW7vVhUsSbNB4iIXbfo5fqj1XHllaKI0y7Y8x4ZBZb8Gjm8oZqA LYpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769686100; x=1770290900; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=itAneaJJLEuJh0bM1d3ExjX/oEb9v6fnFKl3auDIGbw=; b=tY2VmPynDTGVmSobsAVEuFH7vpj5SWs8hZ3NOclyPll2X0OO4IvI4bydiUhyoTxVAf AHvlr1pjBlXZYh5vB9dqY9J9q5ykBPlRNJbG0k40xdeUptcn3B2/UCW9ODa/zY59k+If lMPUFX+uxli9G/LnUSDXTFCR02QD4Oq9ZjgLMPxXMsJEJVPvV/fXjt6+xttbbsb+2npz uF0PzUQH16PvGnxuhHLKlPmp3KhzSAAQ7bmchDMqiJGAWBedyyp09/AcnIR4maWAEDXm pvo/GE7F7rPnLti5yvY8GfISyGZFC9QdyIwKeQT+Sg5WiS+Vph+CTRo1ayFORnVXxCvu oYzg== X-Forwarded-Encrypted: i=1; AJvYcCXmDErd20x+w/hmj45JlJ8uQ0jhlEgYSP7ZyhFZ640aIhDwPUK4NdAYVi5h+A9KjcUKrjsD7A2CnkCvAi0=@vger.kernel.org X-Gm-Message-State: AOJu0YzgWbIWVM+2BMMMZGpbMC4dSgWUF7n9fWbw0Wg9ishU0fPFot90 yBH0K8tHXQEwZj24gHfNM308A3JPdDBimnpaLKCgAa0HmUZ4E8frkBzJw4QhPPeOSCKeKtAlDAg u0J/8hGs3hoTMej8Pq8StmrOCRFbLY7FX4VN554eUkmvxw5jD/hU66oLdiRi8r5UIi4A= X-Gm-Gg: AZuq6aLwL2hyO/+/I5kMzKJLmrs9VXINkl51TLa9KP9lkx5/Mnp6xjAZEqrbj+V47xF 75odhqYc5X85Zb9gXIbs+aDonZGMn8u5b9pDJG3JBGIUpTlQFoPaurs+220+2LwZa/1WSXicH5P /Of53LUWz2/dIRhOmuXajqkrqcI7ekd4Qd04SvwbOWueR+ARFgs/RK/oISktcjE3ANdx534WOKT yH11Oj8gJXKEQiKh1vK103eJ7hPSnBhoUCJhXNrNKZCJHjIgdxQoJcUqt2ni+hSH/IyCcdnbRZm XCVMnZSQdRHrjmv1QuxWt2UZsDSUNdH6UyQa2b0qWdFKY040ZymipQb9S6BGgmpIunzdbnZNpMZ FCNBYNuAh/Y+qvrjXz0i9TFFpvpb5Lj3owXYHKfYC7CKkTyefUZbo8cOW+5/gcqzfeRU= X-Received: by 2002:a0c:e012:0:b0:894:ae65:5ba5 with SMTP id 6a1803df08f44-894d7799679mr54392696d6.2.1769686100608; Thu, 29 Jan 2026 03:28:20 -0800 (PST) X-Received: by 2002:a0c:e012:0:b0:894:ae65:5ba5 with SMTP id 6a1803df08f44-894d7799679mr54392556d6.2.1769686100196; Thu, 29 Jan 2026 03:28:20 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4691e53sm2696913a12.21.2026.01.29.03.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 03:28:18 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 12:28:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: talos: Flatten usb controller nodes To: Krishna Kurapati Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov References: <20260128062720.437712-1-krishna.kurapati@oss.qualcomm.com> <20260128062720.437712-2-krishna.kurapati@oss.qualcomm.com> <2324aa41-6b2a-41ca-9f97-7a5b5e0f575f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: AHebFGhmFzNwk3tROssrKgDSi5sgTfBA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA3NyBTYWx0ZWRfXwYPmss1Wpptw fWUMK4wfBY10uHbn95sBFZW1zu4H2f6ogXxV5lJDLdRBoqYCc5pPlYw+y0bJGBYNbVoyQiLH+fA yPti3hY9rwO7v9h1dbB5XuX9wfWjP0z1lWqECrnRypOmuVT9zPp4XKA/SnrfSI4aRpM7Qvt31Ft UFgTJFFbQxx9gskRZzKSpVNcqbVUUhEn0V4SqUpbn39rXF9ygXuxGDBlv6Sg/oq4ViismKdaeXA l6JwXuuDm8wWsyGKC/10iMENJ3pWV/+V9T6Q3HpnJUl8CwX0Ksjm2zlWQIpbtaPxxcjzNb3+Zb+ Xy4I0byoOz46YE8CAZtyLRyTXZUeZZQ6deeU1AmKXYBPyIL0+uFCnvJP01Y0rnHsuglywX5LokF v6alrFk5ry6lpKKcqXRGq8bdTROBz227bSFgIHW60QLa78v6r1UYo+sY9YKQmdWbAZUb3ncW8RG FzOZFCWXb3s2wx42AtQ== X-Proofpoint-ORIG-GUID: AHebFGhmFzNwk3tROssrKgDSi5sgTfBA X-Authority-Analysis: v=2.4 cv=betmkePB c=1 sm=1 tr=0 ts=697b4455 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mjPXWT5hYa9pg3g40W4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290077 On 1/28/26 5:09 PM, Krishna Kurapati wrote: > > > On 1/28/2026 4:01 PM, Konrad Dybcio wrote: >> On 1/28/26 7:27 AM, Krishna Kurapati wrote: >>> Flatten usb controller nodes and update to using latest bindings >>> and flattened driver approach. >>> >>> Reviewed-by: Dmitry Baryshkov >>> Signed-off-by: Krishna Kurapati >>> --- >> >> Have you checked whether this brings about the same crash-on-suspend >> issue as it does on Hamoa? >> >> https://lore.kernel.org/linux-arm-msm/71c15a78-7a50-4913-b677-e5308fcabfad@packett.cool/ >> > > Hi Konrad, > >  Yes, I did check system suspend use case after flattening and there is no crash seen. > >  The only issue I observed (both before and after flattening) is that waking up from bus suspend, there is an enumeration failure on second port in host mode, and an xHCI CMD_RUN timeout occurs. The issue is gone if we keep controller GDSC flags as RET_ON (not the right solution though). But this issue has nothing to do with flattening. I will sync up with clocks team and try to fix that host mode issue. diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi index 75716b4a58d6..7e7f4eae8a98 100644 --- a/arch/arm64/boot/dts/qcom/talos.dtsi +++ b/arch/arm64/boot/dts/qcom/talos.dtsi @@ -4559,7 +4559,7 @@ usb_2: usb@a8f8800 { <&gcc GCC_AGGRE_USB2_SEC_AXI_CLK>, <&gcc GCC_USB20_SEC_SLEEP_CLK>, <&gcc GCC_USB20_SEC_MOCK_UTMI_CLK>, - <&gcc GCC_USB2_PRIM_CLKREF_CLK>; + <&gcc GCC_USB3_SEC_CLKREF_CLK>; ? Konrad