From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E854A2ED86A for ; Wed, 13 Aug 2025 08:34:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755074099; cv=none; b=eATiZ7JPuqHtssjKTFizo6ET47YT5n5oCFqcuFOqUH78XwJx6Ser2o9SOtBm+JtX28zvlcUCzUDHZphx/NPxozjh6pFaSNxLd66NtSvJueoU5Rqsat3imn5Th5iTRJiIqdAjWuNYnMqN/XPSw0hNyHHaWjjEKw462TRlAFgq4I4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755074099; c=relaxed/simple; bh=BJsNPLCsMWCuoh56cczBIajDM67zaMKaTgolfgD8pys=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BXhcmtuwpSBMkjW8vTq+kzvr/cCI8ggt5Ff7CSHWwReTckCgi/0COeU3nE4nWwAHQt17Y5mnyP7J3eFI2IVX9DbGUO0HeI58dakFIt3HdlUivPsmMTHLw8jljqCYS/3aVhfiB45+xc+W3jvLoxMsx4VBad1cYkKadrrcHAzKEA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b5Y7GJw9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b5Y7GJw9" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57D6mTOi004023 for ; Wed, 13 Aug 2025 08:34:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7vD8uV2t75HZFSBKmavWfIArKi9bpVPP6he9Z/LG/mE=; b=b5Y7GJw9bBvoxizg 4OLMKKLNwyX0N09rL4bO1YeSgL4Jhodi6Mn9Ewoqq+a6HcoNYS61BX0Py6L3CBKV CRI+SbhQRkrIh6EJTJUpbEssUdxUieiGjLnhNF7KKK163KXggMtqM12pomJ7YRfK 2dZnvqdRAVbAoiiIxq2COln0WlUoNma4CxxkEqERtY9uEVaK3PqVo+HPQc78XrSK jduWJfHWPt1+6vOEHYPvMazpANRjtCh9vrfOWrM1VQ1P6BDgFSPUP7Qjuz3GFGwl 4EMZ2UqhBGDuKBvhGw/HOb7mZOcTY8Wy/wfPOmwbFxKO4h8sO8XzdhIuB5niaIA8 k1FWnw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48fm3vp0vk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 13 Aug 2025 08:34:56 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b31f112c90aso571418a12.0 for ; Wed, 13 Aug 2025 01:34:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755074095; x=1755678895; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7vD8uV2t75HZFSBKmavWfIArKi9bpVPP6he9Z/LG/mE=; b=d/66XoNQIBmTihpdeucjoqCZ05iCWDZPdapSv/Wti+wZzASV4iQQ66tdsiSz1v7AIw RgG7ZS2Jszwu7P38Qo+Wlu+wJpbAkSMnVZ+87xXy2o9A+UK2f3RB4VD0SNAOh6/coN/d yOZuwol+Fq1+6NJkmXBOJbI7Qp6Y1mlqQG0J7CP34dXbEKuGypkerIrQnGurCQVXLxR/ yDweXt2eSI+uIXnV00D0HtIRXIOhDbAY5NnJ4g7StIpqiql873XmZ14kjozgjMomvAGK A+tYk5C1+vmYV8i0l2gQ/aDrltCIFbdTOF20aWInGQ5hovt2bivsuzKvN1ig8jVprQG9 H+hA== X-Gm-Message-State: AOJu0YzyK1O1hCzAU2DsKNRSjI0EwR5/Q0/QGIbYsrOIPgQmMddRbBV+ OtNwcYQk3vf1ZOtFRlX18YJu9mo4oSBMjuXNC/POv3OyRKWoR6fqxa7DnteG8+M2AcUDfoAxUk8 gm4QPLNnttEefQaG+oljqfxAoBqtX/hi8VGjTnMV9qcJJ9OqjZ16l0XgrpA756thedoI= X-Gm-Gg: ASbGncuJdHccuAXUFpmJy2sSS4bn0MLC2F8oOw/hAtvaM/BPWUj3Uh7o7puyY4pNaR+ rNDBKePZcOlksqbG2or5BrbwgbgOY6g3yjzfaqBam7NTAR8iO72G3usy64vBg69dtMex6ktHBws kDKZ8tSq1TjS8RJoq5PkzDaQCu3S6gIQSqU7S/ND568deQiaIUprRdD44CcdqOYukDbq+lr6rGU Lgat3ui8xj+D/cnfaBMjoF73DME9gmtFWJITzT2+SE1pxQ4E3HhWdt1qNKRwJRKml7R3v4uQMmW B4xOZtMlar2U/n6yU2eFZihh9/K79p5dIYO8LxCqD9ZhQvYHpqk9A3yhfjE6yBwge51ABro= X-Received: by 2002:a17:902:db02:b0:240:9d6:4554 with SMTP id d9443c01a7336-2430eae02b8mr23183935ad.21.1755074095407; Wed, 13 Aug 2025 01:34:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFtwP6EhgGczqdw69+FCzTPeDqzNTzM6qfuthNnA+SimcTyI9+YyBr8qv6iPBl/3QLmyphKiA== X-Received: by 2002:a17:902:db02:b0:240:9d6:4554 with SMTP id d9443c01a7336-2430eae02b8mr23183465ad.21.1755074094530; Wed, 13 Aug 2025 01:34:54 -0700 (PDT) Received: from [10.92.180.108] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241d1f0f7ccsm318630375ad.57.2025.08.13.01.34.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Aug 2025 01:34:54 -0700 (PDT) Message-ID: Date: Wed, 13 Aug 2025 14:04:46 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: sm8450: Flatten usb controller node To: Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org, Konrad Dybcio , Bjorn Andersson , Conor Dooley , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, Konrad Dybcio References: <20250715052739.3831549-1-krishna.kurapati@oss.qualcomm.com> <20250715052739.3831549-3-krishna.kurapati@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODExMDEwNyBTYWx0ZWRfX98Z1McidPjHc Y9cq2VIrigWQ80hxqY8bJoP/bbHM3ljk3xa//di+wsEj/ONTP5XSCrugnS02D0Cu9gL9Xfypx4o oNzvaMGJGrA53t2wS8A1e7/Z5fKfJc0W50+RJdLF3x8WFCmcPj6cVkKw+jznK8zrtJUz59BRxuY FQszynrUAQbc2OyfqoJ7emsdyG89mJe+sBhNkCuKSJrsVZ+DxM6O1RI/vzWbYADebxTY0lvW0KR fLxsAvt/+yhzDtcvvoQdMl2abyPAfizk+N3SbQOAYJDh05ku4hlJtDuzQC48Eyg17ca/lDZpM8W 6fO19+7+aw1Jq98MchegXkpyszsfztxhfmR0eJE/zzBp7VMQ0nH03jV+BZ2WT+OBYLoULcBEBuC C3KlN1Zh X-Proofpoint-GUID: CjKvWjmd5KiGlHXVegLRF1dxYa33D0Ih X-Authority-Analysis: v=2.4 cv=A+1sP7WG c=1 sm=1 tr=0 ts=689c4e30 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=vr-wfZUyanrvw1r9NhMA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: CjKvWjmd5KiGlHXVegLRF1dxYa33D0Ih X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-12_08,2025-08-11_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508110107 On 8/13/2025 12:57 PM, Krzysztof Kozlowski wrote: > On 15/07/2025 07:27, Krishna Kurapati wrote: >> Flatten usb controller node and update to using latest bindings >> and flattened driver approach. >> >> Reviewed-by: Konrad Dybcio >> Signed-off-by: Krishna Kurapati >> --- >> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 5 -- >> .../dts/qcom/sm8450-sony-xperia-nagara.dtsi | 5 +- >> arch/arm64/boot/dts/qcom/sm8450.dtsi | 57 +++++++++---------- >> 3 files changed, 27 insertions(+), 40 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> index 2ff40a120aad..0c6aa7ddf432 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> @@ -1199,11 +1199,6 @@ &usb_1 { >> status = "okay"; >> }; >> >> -&usb_1_dwc3 { >> - dr_mode = "otg"; >> - usb-role-switch; >> -}; >> - >> &usb_1_dwc3_hs { >> remote-endpoint = <&pmic_glink_hs_in>; >> }; >> diff --git a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi >> index cc1335a07a35..6bd315e10992 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8450-sony-xperia-nagara.dtsi >> @@ -781,11 +781,8 @@ &uart7 { >> }; >> >> &usb_1 { >> - status = "okay"; >> -}; >> - >> -&usb_1_dwc3 { >> dr_mode = "peripheral"; >> + status = "okay"; >> }; >> >> &usb_1_hsphy { >> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> index 54c6d0fdb2af..89dbac3bdd2b 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >> @@ -5417,12 +5417,9 @@ opp-202000000 { >> }; >> >> usb_1: usb@a6f8800 { >> - compatible = "qcom,sm8450-dwc3", "qcom,dwc3"; >> - reg = <0 0x0a6f8800 0 0x400>; >> + compatible = "qcom,sm8450-dwc3", "qcom,snps-dwc3"; >> + reg = <0 0x0a600000 0 0xfc100>; > > > So this was never checked. Can you start using tools before you send > code upstream? > > Hi Krzysztof, Apologies. I didn't compile it with W=1 previously. When I did after the kernel test robot complained, I saw the issue. Also I rebased it on top of latest linux next where I see the flattened patch is present. Regards, Krishna,