From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C26B2248AC; Thu, 19 Dec 2024 12:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734611409; cv=none; b=TYdCiFJBBEN6Evq33w7lztqFpmr6Dlr6oDBN91M5VCNYzbYCN5XTyb+8d0Jah7iDWNCf2b/LIuxJXZTnnnMl0PL4prh9c9L3sjVyHcEtceUnfyIVSncSJ685IE2MySeD13OG51DV8QZ2ot3fzaNvCpAbnIAnXK5faDfKI8gt06M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734611409; c=relaxed/simple; bh=U0odsYw1Ce7tVoBc6QflHBSzxDVw7Swh/FxE+OlLt64=; h=Message-ID:Date:MIME-Version:CC:Subject:To:References:From: In-Reply-To:Content-Type; b=AyA1UKZi0by2xtQlSWKeSBc1esWfKZM38N0UTgHat6Ux6bR+frmpsmd/Nbs0e7hRCrb4SKvSucgKXsv7ZM1XXziWvt+5p5l4NXhcnae+dbDJDSBp5/E9MTC5vEBsr9lM1t7ZQeHBOZRwOa+FRMQT2pKLvmqFZditZuSsmJWauu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4YDVH749Lcz1JFnH; Thu, 19 Dec 2024 20:29:39 +0800 (CST) Received: from kwepemk100013.china.huawei.com (unknown [7.202.194.61]) by mail.maildlp.com (Postfix) with ESMTPS id 6790C140202; Thu, 19 Dec 2024 20:30:03 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemk100013.china.huawei.com (7.202.194.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 19 Dec 2024 20:30:02 +0800 Message-ID: Date: Thu, 19 Dec 2024 20:30:01 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , Subject: Re: [PATCH net-next v2 4/4] net: hisilicon: hns: Remove unused enums To: , , , , , , , References: <20241218163341.40297-1-linux@treblig.org> <20241218163341.40297-5-linux@treblig.org> From: Jijie Shao In-Reply-To: <20241218163341.40297-5-linux@treblig.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemk100013.china.huawei.com (7.202.194.61) on 2024/12/19 0:33, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The enums dsaf_roce_port_mode, dsaf_roce_port_num and dsaf_roce_qos_sl > are unused after the removal of the reset code. > > Remove them. Thanks, Reviewed-by: Jijie Shao > > Signed-off-by: Dr. David Alan Gilbert > --- > .../ethernet/hisilicon/hns/hns_dsaf_main.h | 23 ------------------- > 1 file changed, 23 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h > index bb8267aafc43..653dfbb25d1b 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h > +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h > @@ -42,29 +42,6 @@ struct hns_mac_cb; > > #define HNS_MAX_WAIT_CNT 10000 > > -enum dsaf_roce_port_mode { > - DSAF_ROCE_6PORT_MODE, > - DSAF_ROCE_4PORT_MODE, > - DSAF_ROCE_2PORT_MODE, > - DSAF_ROCE_CHAN_MODE_NUM, > -}; > - > -enum dsaf_roce_port_num { > - DSAF_ROCE_PORT_0, > - DSAF_ROCE_PORT_1, > - DSAF_ROCE_PORT_2, > - DSAF_ROCE_PORT_3, > - DSAF_ROCE_PORT_4, > - DSAF_ROCE_PORT_5, > -}; > - > -enum dsaf_roce_qos_sl { > - DSAF_ROCE_SL_0, > - DSAF_ROCE_SL_1, > - DSAF_ROCE_SL_2, > - DSAF_ROCE_SL_3, > -}; > - > #define DSAF_STATS_READ(p, offset) (*((u64 *)((u8 *)(p) + (offset)))) > #define HNS_DSAF_IS_DEBUG(dev) ((dev)->dsaf_mode == DSAF_MODE_DISABLE_SP) >