From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2938FC761A6 for ; Tue, 4 Apr 2023 05:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233270AbjDDFTC (ORCPT ); Tue, 4 Apr 2023 01:19:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjDDFS7 (ORCPT ); Tue, 4 Apr 2023 01:18:59 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2178E1BF3; Mon, 3 Apr 2023 22:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680585539; x=1712121539; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=6gSgt1TtaxCXHALsYW5lDdEPQQMuML7hRMzWJG2ZTDA=; b=fPbmwM5QHlsDPuZqJkijeCCDTwi7Ah4kWBwET7AxpC3d4osMQ36BDDrs FgdfFeLULbkbZx+3oNFslTa1Ap0SnmliM8RKuwlIpz3/4yLIggIOAne1U AjyMJzJsGV/T4Z4tSBGfiViD6yb6MeSx8NmmonxzWmmioeNViqtE4AD5o s5/1pHittLPULf4ux69kjk+XeWKhg4atTMV2bVvp8agVD8n4uPMMMou9D NHv6TgqzM+AkF7xxX8R+61/KjdnNAOWzzdcynrKYem5oJ2RoTZ225He7k O97CKZzpiC3t/1NrAvbcM0j5jBxVtEdKKDPxxnS+JOTW0jm9uG/AkTAT0 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="342115125" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="342115125" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 22:18:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="829838790" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="829838790" Received: from allen-box.sh.intel.com (HELO [10.239.159.48]) ([10.239.159.48]) by fmsmga001.fm.intel.com with ESMTP; 03 Apr 2023 22:18:55 -0700 Message-ID: Date: Tue, 4 Apr 2023 13:19:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Fenghua Yu , Vinod Koul , Jacob Pan , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] dmaengine: idxd: Add enable/disable device IOPF feature Content-Language: en-US To: Dave Jiang , iommu@lists.linux.dev, dmaengine@vger.kernel.org References: <20230324120234.313643-1-baolu.lu@linux.intel.com> <20230324120234.313643-2-baolu.lu@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/23 12:57 AM, Dave Jiang wrote: > On 4/2/23 10:49 PM, Baolu Lu wrote: >> On 3/24/23 8:02 PM, Lu Baolu wrote: >>> The iommu subsystem requires IOMMU_DEV_FEAT_IOPF must be enabled before >>> and disabled after IOMMU_DEV_FEAT_SVA, if device's I/O page faults rely >>> on the IOMMU. Add explicit IOMMU_DEV_FEAT_IOPF enabling/disabling in >>> this >>> driver. >>> >>> At present, missing IOPF enabling/disabling doesn't cause any real >>> issue, >>> because the IOMMU driver places the IOPF enabling/disabling in the path >>> of SVA feature handling. But this may change. >>> >>> Reviewed-by: Dave Jiang >>> Reviewed-by: Fenghua Yu >>> Reviewed-by: Kevin Tian >>> Signed-off-by: Lu Baolu >> >> Hi Dave and Fenghua, >> >> The following iommu patches depends on this one. Can I route it to >> Linus through the iommu tree? > > Hi Baolu, you'll need an ack from Vinod, who is the dmaengine subsystem > maintainer. I have no objections. Hi Vinod, Does this work work for you? Best regards, baolu