Re: [PATCH 1/2] hfsplus: make splice write available again

[Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>]

On Thu, 2025-05-29 at 08:00 -0600, Yangtao Li wrote:
> Since 5.10, splice() or sendfile() return EINVAL. This was
> caused by commit 36e2c7421f02 ("fs: don't allow splice read/write
> without explicit ops").
> 
> This patch initializes the splice_write field in file_operations, like
> most file systems do, to restore the functionality.
> 
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  fs/hfsplus/inode.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index f331e9574217..c85b5802ec0f 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -368,6 +368,7 @@ static const struct file_operations hfsplus_file_operations = {
>  	.write_iter	= generic_file_write_iter,
>  	.mmap		= generic_file_mmap,
>  	.splice_read	= filemap_splice_read,
> +	.splice_write	= iter_file_splice_write,
>  	.fsync		= hfsplus_file_fsync,
>  	.open		= hfsplus_file_open,
>  	.release	= hfsplus_file_release,

Makes sense.

Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>

Thanks,
Slava.