From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: David Miller <davem@davemloft.net>
Cc: bh74.an@samsung.com, ks.giri@samsung.com,
vipul.pandya@samsung.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: Avoid deadlock situation due to use of xmit_lock
Date: Tue, 6 Dec 2016 20:10:36 +0100 [thread overview]
Message-ID: <fa4812b6-fa7c-9fa2-d1c2-c91adab93426@gmx.de> (raw)
In-Reply-To: <20161206.100607.919832811727709338.davem@davemloft.net>
Hi,
On 06.12.2016 16:06, David Miller wrote:
> From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
> Date: Sat, 3 Dec 2016 00:06:04 +0100
>
>> after stumbling over a potential deadlock situation in the altera driver
>> (see http://marc.info/?l=linux-netdev&m=148054615230447&w=2), I checked
>> all other ethernet drivers for the same issue and actually found it in 2
>> more, namely stmmac, and sxgbe. Please see the commit messages for a
>> description of the problem.
>> These 2 patches fix the concerning drivers.
>
> First of all, I don't want to apply these patches without proper testing
> and ACKs from the individual driver maintainers.
>
> For both of these drivers, this situation only exists because the TX
> path uses the unnecessary ->tx_lock. This private lock should be
> removed completely and the driver should use the lock the mid-layer
> already holds in the transmit path and take it in the TX reclaim path
> instead of the private ->tx_lock.
>
Ok, I will prepare a new set of patches to remove those private locks entirely.
Regards,
Lino
prev parent reply other threads:[~2016-12-06 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 23:06 Lino Sanfilippo
2016-12-02 23:06 ` [PATCH 1/2] net: ethernet: sxgbe: do not use xmit_lock in tx completion handler Lino Sanfilippo
2016-12-02 23:06 ` [PATCH 2/2] net: ethernet: stmmac: " Lino Sanfilippo
2016-12-06 15:06 ` Avoid deadlock situation due to use of xmit_lock David Miller
2016-12-06 19:10 ` Lino Sanfilippo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa4812b6-fa7c-9fa2-d1c2-c91adab93426@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=alexandre.torgue@st.com \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=ks.giri@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®