From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB279C7EE24 for ; Fri, 2 Jun 2023 10:31:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235661AbjFBKbw (ORCPT ); Fri, 2 Jun 2023 06:31:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236026AbjFBKaW (ORCPT ); Fri, 2 Jun 2023 06:30:22 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6756A1FF0 for ; Fri, 2 Jun 2023 03:28:31 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27AE412FC; Fri, 2 Jun 2023 03:27:54 -0700 (PDT) Received: from [10.57.22.125] (unknown [10.57.22.125]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5924C3F7BD; Fri, 2 Jun 2023 03:27:07 -0700 (PDT) Message-ID: Date: Fri, 2 Jun 2023 11:27:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH 2/4] ACPI/APMT: Don't register invalid resource To: Robin Murphy , will@kernel.org Cc: mark.rutland@arm.com, bwicaksono@nvidia.com, ilkka@os.amperecomputing.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla References: <91c8787f1e84d79e110a057615c838f6ac244669.1685619571.git.robin.murphy@arm.com> From: Suzuki K Poulose In-Reply-To: <91c8787f1e84d79e110a057615c838f6ac244669.1685619571.git.robin.murphy@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2023 12:59, Robin Murphy wrote: > Don't register a resource for the second page unless the dual-page > extension flag is actually present to say it's valid. > > CC: Lorenzo Pieralisi > CC: Hanjun Guo > CC: Sudeep Holla > Signed-off-by: Robin Murphy > --- > > Not a critical fix, since the driver currently works around this itself, > but patch #4 would like to clean that up. > > drivers/acpi/arm64/apmt.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/arm64/apmt.c b/drivers/acpi/arm64/apmt.c > index 8cab69fa5d59..aa7d5c3c0dd8 100644 > --- a/drivers/acpi/arm64/apmt.c > +++ b/drivers/acpi/arm64/apmt.c > @@ -35,11 +35,13 @@ static int __init apmt_init_resources(struct resource *res, > > num_res++; > > - res[num_res].start = node->base_address1; > - res[num_res].end = node->base_address1 + SZ_4K - 1; > - res[num_res].flags = IORESOURCE_MEM; > + if (node->flags & ACPI_APMT_FLAGS_DUAL_PAGE) { > + res[num_res].start = node->base_address1; > + res[num_res].end = node->base_address1 + SZ_4K - 1; > + res[num_res].flags = IORESOURCE_MEM; > > - num_res++; > + num_res++; > + } > > if (node->ovflw_irq != 0) { > trigger = (node->ovflw_irq_flags & ACPI_APMT_OVFLW_IRQ_FLAGS_MODE); Reviewed-by: Suzuki K Poulose