From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E392E81807 for ; Tue, 26 Sep 2023 00:44:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231989AbjIZAoa (ORCPT ); Mon, 25 Sep 2023 20:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbjIZAo3 (ORCPT ); Mon, 25 Sep 2023 20:44:29 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1573E109; Mon, 25 Sep 2023 17:44:23 -0700 (PDT) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38Q0iKm7018355; Tue, 26 Sep 2023 00:44:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=m++FehUKo02CiCUlx0uKOTnEn0sFhrrb6tD0q8PkWjo=; b=dGhFmfwj0dy1eQeCqbnO1XVcQbq5AFQ8I4k8cCnoNjx7qGC2NcJYX/d2Bk7sGbclfk6I sLnPgqrGP/1Y4RsgwbAaTOqXJRgN8y42GpZX8dyypBYubFPRUCdw7UTJA9Z5oPiHMxP9 rKkr6DvMTZQC7tldrH1xXqDTEWgbOGezDj1I4WXf/ZLCLIsz65lsMVu8L2joHisYEtXf AD4ShdzNejJQ2by59zjw31iCGbmvdaKwS+buXmr2zhgEuqXLth6pctYim9FH11n3AEYJ VfKq2+Ydht3MDIbqPEQ9w8jjWcSM4Jqxita6Q9H64YlRsxfWktcmA8JG3N9SJVX8a3aK 1A== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3tb72shw0a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Sep 2023 00:44:20 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38Q0iJRA000424 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Sep 2023 00:44:19 GMT Received: from [10.48.244.213] (10.49.16.6) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Mon, 25 Sep 2023 17:44:18 -0700 Message-ID: Date: Mon, 25 Sep 2023 17:44:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH wireless 1/2] ath: dfs_pattern_detector: Fix a memory initialization issue Content-Language: en-US To: Christophe JAILLET , Kalle Valo CC: , , "Kalle Valo" , References: From: Jeff Johnson In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: ZSesB_QrY5Flyd5Q6dum--C_XB-GP0sj X-Proofpoint-ORIG-GUID: ZSesB_QrY5Flyd5Q6dum--C_XB-GP0sj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-25_19,2023-09-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 malwarescore=0 adultscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309260003 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/23/2023 11:57 PM, Christophe JAILLET wrote: > If an error occurs and channel_detector_exit() is called, it relies on > entries of the 'detectors' array to be NULL. > Otherwise, it may access to un-initialized memory. > > Fix it and initialize the memory, as what was done before the commit in > Fixes. > > Fixes: a063b650ce5d ("ath: dfs_pattern_detector: Avoid open coded arithmetic in memory allocation") > Signed-off-by: Christophe JAILLET Reviewed-by: Jeff Johnson