From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 160A43AAF57 for ; Mon, 24 Aug 2026 08:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787560030; cv=none; b=Og6SPRQqXkQF+m6iN+MHBOJ81EgL/Jo0OuFOlswLyAB17sXKj9lAjtjBhWAou59uS8Zy5FPWWjd4uEiWZJLr64IzPiPIkXTDYMIpM2jRw5oc1TysIJ0Wzo2KzsWUNTfnobkSHXmzgTAjDTqn//5+qA6Had3dqnrhdEYAURAgwnI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787560030; c=relaxed/simple; bh=iO0WOKLJYHeCiXQSmFOX5WJAULuW7dOAGV7QorpsBUk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s1b2NYrMKINykNRt33GSp8IMBf4wIs6+BFqAAt4/Cf8UnIUwrPuA3pIAoqyAqYRK8aH+1amQsj+T3n2wyLQD5uwnKonPKjuFpSW3prBqvX7erhhpcgrMahN5UOi6lDxdgQsKRgMAcJke/XTTc0S9kXCuSm9KOpCPq1fOW3Oa+QM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Li6i+my+; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Li6i+my+" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso3409256a91.3 for ; Mon, 24 Aug 2026 01:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787560028; x=1788164828; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HSkAieVQa1JTe8qhVM2kCKaOCfjEKvx10b2NLcrDjss=; b=Li6i+my+RObq+pYRpLSpe5E4RzyT3+WAmEFguA7HVF2EZR2kwAVTT4XmNxwF/PdVXK hnOnp7zD0wKktcXB1Ubn1Hit4FESUEQnrXwisjlRXib5gytmLxWg5enilp/TLQw71Grp 69Qq8Bi9IKkuxyNCsMwLXthMU/8X8J440a81n13paNuJWwlIn+CZRUaL/bvaPzekmoMd o3CH8fmbieZHPMEAHMr90IJyPbmujjfttEz8gqgEOJ4BNry/A7s3Yh7GClKO3l6lVrVS k1eKSChCY5+BW1DmVzxXqnNMiwWz/rEC2rag+NXL/7r+7/oVNlAR3MB6zr6qPZmjL9pO 2BJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787560028; x=1788164828; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HSkAieVQa1JTe8qhVM2kCKaOCfjEKvx10b2NLcrDjss=; b=Okw44BvBiuN3p/M2XHHXh7HOj2MaOGjqQdc+I++rGxUrAWbZ0r0Ofx7PiaZ63x9ZMN uMgPW2uq3RgUExI2ItJ9rzwdzDIlQExgsD7ZH5IHnLIL7HxSYALuKwYFR6gOcUzzRW8q kWoLhJq5kBfXVPgn7AqC5kvh1udeyo87uxtw+B/T0nxT225lOibO777VYYst4dBCIoO+ UNB+qnTl0CuvcjYtKM12oZbv6gU0diuTC3qdUB2A7oOWQSk1i74jutDCylu/tr2tDTqC oJntfx4tRxHicosMGyE6ncg0AzMXw1bytgnwdwtuhQoXWLc0/iZ+1C6wBruZc0sKnQ6H Hrlw== X-Forwarded-Encrypted: i=1; AHgh+RpgrhqaUaJGts0eu+ywT/j9tJoqIkPnTI2uCTngDvbFeCmqxiMQadC5iQonuVRyvdLUXFvOxiyPGt9yLIM=@vger.kernel.org X-Gm-Message-State: AFuF++nCaP/FfhMgEBuYwHtOSZhiDxjMxkjxP8JGpNakw5XtscTa4NfQ nYnVN+NLPHwoSHtuCGnPIlDBWb0ffJG5SKnpddy3eMVlIqZLGzCBYx/JbAUi3XM6 X-Gm-Gg: AR+sD10BziK9qdgYSYOnYhlKc6cyfHnH9Ttzj0cxPExmwNvnq9FGSjj7mCtSJDxWjts yDXVT+TYxv2DvKjuGPAdQzeQR7jsrRZZv5sZTVVPiBZtbh1G4JdBHXA78tndMpLeifubdNdcvvU BQIyi0eFrHlrrNrYNk7S+O4teoZnpLrKH68fVMqv4suRhx2gcz0vrBVa/s3FFjL+5HRTwnwDr3C +XB5b8o9+2SefC5kg13Zk/B2kjLXmhzv66RQ9QKdbxmN46zMbDKV+4SrXJXEgmLrOcNeIhgqIEK EQKXvJsC4Wav4AGOx3YidWyzNFfJM61uQvLN2km0XCpX0ztiwjz64CvKIz25OhEkVcSEbFOJIUf pR3ZTo7hkTswPIcTZnNWEFDC9qkmJxMtQu0bZdjNHnYwA3LiTTDYNUo/VJ5U4qEv8Cv/Xxj0fro i+GCbxhO8mCOAsq0+O1lLUfXzB8ry7lWafyAXLMRwbTgExg6JQ4aStO3P3olifGuI2TiOovDVk3 4mFuY9dLW4YcdvD0cUuQ8MuhkwT2uv3PZHA6Pb53GDXhTwHu1Iu225Xi9scR0+72KMZrDvHIxGr O2w+L/mFjo2UaUdO6sXvdIsIyF7h3oNr33i/kKY4nftQ6U6U5zIfHSRTmvaGZm/O7Na5RQfdOwu rh9qbuQFy6h1ez9XkRqg50ijnWYAG2rnsYTEa+31S0ftbLoE= X-Received: by 2002:a17:90b:50c3:b0:395:5eec:b932 with SMTP id 98e67ed59e1d1-395c39e6433mr48365891a91.11.1787560027941; Mon, 24 Aug 2026 01:27:07 -0700 (PDT) Received: from localhost.localdomain ([101.251.7.10]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-327f90c0dd3sm25994595eec.7.2026.08.24.01.27.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 24 Aug 2026 01:27:07 -0700 (PDT) From: Laxman Acharya Padhya To: Sven Peter , Janne Grunau Cc: Neal Gompa , Arnd Bergmann , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2 4/4] soc: apple: rtkit: rate limit malformed syslog warnings Date: Mon, 24 Aug 2026 14:11:40 +0545 Message-ID: X-Mailer: git-send-email 2.51.2 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The coprocessor can repeatedly send malformed syslog messages and flood the kernel log with warnings. Use the rate-limited warning helper for the validation failures in the syslog receive path. Fixes: 9bd1d9a0d8bb ("soc: apple: Add RTKit IPC library") Cc: stable@vger.kernel.org Signed-off-by: Laxman Acharya Padhya --- drivers/soc/apple/rtkit.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c index da766df5a6d7..e70e3d2cfa08 100644 --- a/drivers/soc/apple/rtkit.c +++ b/drivers/soc/apple/rtkit.c @@ -439,7 +439,8 @@ static void apple_rtkit_syslog_rx_init(struct apple_rtkit *rtk, u64 msg) rtk->syslog_msg_size = FIELD_GET(APPLE_RTKIT_SYSLOG_MSG_SIZE, msg); if (rtk->syslog_msg_size == 0) { - dev_warn(rtk->dev, "RTKit: syslog msg_size is zero\n"); + dev_warn_ratelimited(rtk->dev, + "RTKit: syslog msg_size is zero\n"); return; } @@ -464,26 +465,24 @@ static void apple_rtkit_syslog_rx_log(struct apple_rtkit *rtk, u64 msg) int msglen; if (!rtk->syslog_msg_buffer || rtk->syslog_msg_size == 0) { - dev_warn( - rtk->dev, - "RTKit: received syslog message but no syslog_msg_buffer\n"); + dev_warn_ratelimited(rtk->dev, + "RTKit: received syslog message but no syslog_msg_buffer\n"); goto done; } if (!rtk->syslog_buffer.size) { - dev_warn( - rtk->dev, - "RTKit: received syslog message but syslog_buffer.size is zero\n"); + dev_warn_ratelimited(rtk->dev, + "RTKit: received syslog message but syslog_buffer.size is zero\n"); goto done; } if (!rtk->syslog_buffer.buffer && !rtk->syslog_buffer.iomem) { - dev_warn( - rtk->dev, - "RTKit: received syslog message but no syslog_buffer.buffer or syslog_buffer.iomem\n"); + dev_warn_ratelimited(rtk->dev, + "RTKit: received syslog message but no syslog_buffer.buffer or syslog_buffer.iomem\n"); goto done; } if (idx >= rtk->syslog_n_entries) { - dev_warn(rtk->dev, "RTKit: syslog index %d out of range\n", - idx); + dev_warn_ratelimited(rtk->dev, + "RTKit: syslog index %d out of range\n", + idx); goto done; } -- 2.51.2