From: "wuqiang.matt" <wuqiang.matt@bytedance.com>
To: Frederic Weisbecker <frederic@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 09/19] lib: test_objpool: Use kthread_run_on_cpu()
Date: Wed, 14 Aug 2024 10:53:12 +0800 [thread overview]
Message-ID: <fa57bdec-0b29-4e6f-92c8-a223cdbd9ff0@bytedance.com> (raw)
In-Reply-To: <20240807160228.26206-10-frederic@kernel.org>
On 2024/8/8 00:02, Frederic Weisbecker wrote:
> Use the proper API instead of open coding it.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> ---
> lib/test_objpool.c | 19 +++++--------------
> 1 file changed, 5 insertions(+), 14 deletions(-)
>
> diff --git a/lib/test_objpool.c b/lib/test_objpool.c
> index bfdb81599832..2c09dd91e731 100644
> --- a/lib/test_objpool.c
> +++ b/lib/test_objpool.c
> @@ -371,14 +371,10 @@ static int ot_start_sync(struct ot_test *test)
> if (!cpu_online(cpu))
> continue;
>
> - work = kthread_create_on_node(ot_thread_worker, item,
> - cpu_to_node(cpu), "ot_worker_%d", cpu);
> - if (IS_ERR(work)) {
> + work = kthread_run_on_cpu(ot_thread_worker, item,
> + cpu, "ot_worker_%d");
> + if (IS_ERR(work))
> pr_err("failed to create thread for cpu %d\n", cpu);
> - } else {
> - kthread_bind(work, cpu);
> - wake_up_process(work);
> - }
> }
>
> /* wait a while to make sure all threads waiting at start line */
> @@ -562,14 +558,9 @@ static int ot_start_async(struct ot_test *test)
> if (!cpu_online(cpu))
> continue;
>
> - work = kthread_create_on_node(ot_thread_worker, item,
> - cpu_to_node(cpu), "ot_worker_%d", cpu);
> - if (IS_ERR(work)) {
> + work = kthread_run_on_cpu(ot_thread_worker, item, cpu, "ot_worker_%d");
> + if (IS_ERR(work))
> pr_err("failed to create thread for cpu %d\n", cpu);
> - } else {
> - kthread_bind(work, cpu);
> - wake_up_process(work);
> - }
> }
>
> /* wait a while to make sure all threads waiting at start line */
Looks good to me. Thanks for the simplification.
Reviewed-by: Matt Wu <wuqiang.matt@bytedance.com>
next prev parent reply other threads:[~2024-08-14 2:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 16:02 [PATCH 00/19] kthread: Introduce preferred affinity v2 Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 01/19] arm/bL_switcher: Use kthread_run_on_cpu() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 02/19] x86/resctrl: " Frederic Weisbecker
2024-12-02 15:19 ` [tip: x86/cache] " tip-bot2 for Frederic Weisbecker
2024-12-13 21:02 ` tip-bot2 for Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 03/19] firmware: stratix10-svc: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 04/19] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 05/19] scsi: bnx2i: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 06/19] scsi: qedi: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 07/19] soc/qman: test: Use kthread_run_on_cpu() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 08/19] kallsyms: " Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 09/19] lib: test_objpool: " Frederic Weisbecker
2024-08-14 2:53 ` wuqiang.matt [this message]
2024-08-07 16:02 ` [PATCH 10/19] net: pktgen: Use kthread_create_on_node() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 11/19] kthread: Make sure kthread hasn't started while binding it Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 12/19] kthread: Default affine kthread to its preferred NUMA node Frederic Weisbecker
2024-08-07 17:01 ` Vlastimil Babka
2024-08-07 16:02 ` [PATCH 13/19] mm: Create/affine kcompactd to its preferred node Frederic Weisbecker
2024-08-07 17:02 ` Vlastimil Babka
2024-08-07 16:02 ` [PATCH 14/19] mm: Create/affine kswapd " Frederic Weisbecker
2024-08-07 17:05 ` Vlastimil Babka
2024-08-07 16:02 ` [PATCH 15/19] kthread: Implement preferred affinity Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 16/19] rcu: Use kthread preferred affinity for RCU boost Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 17/19] kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 18/19] treewide: Introduce kthread_run_worker[_on_cpu]() Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 19/19] rcu: Use kthread preferred affinity for RCU exp kworkers Frederic Weisbecker
2024-09-16 22:49 [PATCH 00/19] kthread: Introduce preferred affinity v3 Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 09/19] lib: test_objpool: Use kthread_run_on_cpu() Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa57bdec-0b29-4e6f-92c8-a223cdbd9ff0@bytedance.com \
--to=wuqiang.matt@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome