From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F742C5CFC3 for ; Mon, 18 Jun 2018 17:12:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AB9E205C9 for ; Mon, 18 Jun 2018 17:12:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AB9E205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935257AbeFRRMB (ORCPT ); Mon, 18 Jun 2018 13:12:01 -0400 Received: from mga07.intel.com ([134.134.136.100]:22649 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932762AbeFRRL7 (ORCPT ); Mon, 18 Jun 2018 13:11:59 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2018 10:11:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,240,1526367600"; d="scan'208";a="50853753" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.143]) ([10.7.153.143]) by orsmga006.jf.intel.com with ESMTP; 18 Jun 2018 10:11:59 -0700 Subject: Re: [PATCH linux-next v5 07/13] dt-bindings: mfd: Add a document for PECI client mfd To: Lee Jones Cc: Mark Rutland , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Andrew Jeffery , James Feist , Jason M Biils , Joel Stanley , Vernon Mauery References: <20180601182216.23894-1-jae.hyun.yoo@linux.intel.com> <20180613061637.GI5278@dell> <2b5bbf01-8c9c-bb06-4559-00dae61d95de@linux.intel.com> <20180618060306.GD31141@dell> From: Jae Hyun Yoo Message-ID: Date: Mon, 18 Jun 2018 10:11:58 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180618060306.GD31141@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/17/2018 11:03 PM, Lee Jones wrote: > On Thu, 14 Jun 2018, Jae Hyun Yoo wrote: > > [...] > >>>> +Example: >>>> + peci-bus@0 { >>> >>> 0? >>> >> >> Because the actual reg value of the peci bus is reg = <0x0 0x60> but >> anyway it's an example. >> >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>> >>> No 'reg' property? > > 0 is fine, but you really should have a 'reg' property. > Okay, I'll add reg setting example. >> This is the actual peci bus node which is a parent of this MFD node: >> peci0: peci-bus@0 { >> compatible = "aspeed,ast2500-peci"; >> reg = <0x0 0x60>; >> #address-cells = <1>; >> #size-cells = <0>; >> interrupts = <15>; >> clocks = <&syscon ASPEED_CLK_GATE_REFCLK>; >> resets = <&syscon ASPEED_RESET_PECI>; >> clock-frequency = <24000000>; >> msg-timing = <1>; >> addr-timing = <1>; >> rd-sampling-point = <8>; >> cmd-timeout-ms = <1000>; >> }; >> >>>> + < more properties > >>> >>> Remove this. >> >> I dropped all other properties into < more properties > because I want >> to show the #address-cells and #size-cells to state its sub-nodes >> should have a single unique reg value. Should I remove this line or the >> whole parent node? > > Just drop the properties which are unimportant for the example. You > do not need to replace them with anything, especially with a non-DT > compliant string. > Okay, I'll fix it. Thanks a lot! >>>> + peci-client@30 { >>>> + compatible = "intel,peci-client", "simple-mfd"; >>>> + reg = <0x30>; >>>> + }; >>>> + >>>> + peci-client@31 { >>>> + compatible = "intel,peci-client", "simple-mfd"; >>>> + reg = <0x31>; >>>> + }; >>>> + }; >>> >