From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933519AbeAKVvt (ORCPT + 1 other); Thu, 11 Jan 2018 16:51:49 -0500 Received: from vern.gendns.com ([206.190.152.46]:40385 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932790AbeAKVvq (ORCPT ); Thu, 11 Jan 2018 16:51:46 -0500 Subject: Re: [PATCH v5 17/44] dt-bindings: clock: Add bindings for DA8XX CFGCHIP gate clocks To: Rob Herring Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Mark Rutland , Sekhar Nori , Kevin Hilman , Adam Ford , linux-kernel@vger.kernel.org References: <1515377863-20358-1-git-send-email-david@lechnology.com> <1515377863-20358-18-git-send-email-david@lechnology.com> <20180111214516.quplp3kwwfrzocfp@rob-hp-laptop> From: David Lechner Message-ID: Date: Thu, 11 Jan 2018 15:51:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180111214516.quplp3kwwfrzocfp@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/11/2018 03:45 PM, Rob Herring wrote: > On Sun, Jan 07, 2018 at 08:17:16PM -0600, David Lechner wrote: >> This adds a new binding for the gate clocks present in the CFGCHIP syscon >> registers in TI DA8XX SoCs. There are actually other gate clocks in this >> block that could be added in the future, but TBCLK is currently the only >> one being used. > > Like how many? 2 more?, then fine. 20 more, then perhaps cfgchip should > be the clock provider. Like, one more. Same goes for the mux clock. The USB PHY clocks are also part of the CFGCHIP. All of these clocks are randomly spread out, so I didn't really see a logical way to make a single clock provider with #clock-cells = <1>. > > In any case, I'd prefer to see all the cfgchip clocks documented in one > doc. I will do that.