From: Bart Van Assche <bvanassche@acm.org>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, avri.altman@wdc.com,
alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
alice.chao@mediatek.com, powen.kao@mediatek.com,
mason.zhang@mediatek.com, qilin.tan@mediatek.com,
lin.gui@mediatek.com, eddie.huang@mediatek.com,
tun-yu.yu@mediatek.com, cc.chou@mediatek.com,
chaotian.jing@mediatek.com, jiajie.hao@mediatek.com
Subject: Re: [PATCH v2 2/5] scsi: ufs: ufs-mediatek: Provide detailed description for UIC errors
Date: Wed, 27 Jul 2022 10:57:56 -0700 [thread overview]
Message-ID: <fa60e605-a881-79aa-b9ed-9c8bdf06778f@acm.org> (raw)
In-Reply-To: <20220727034454.31892-3-stanley.chu@mediatek.com>
On 7/26/22 20:44, Stanley Chu wrote:
> diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediatek.h
> index aa26d415527b..9017ab8f9867 100644
> --- a/drivers/ufs/host/ufs-mediatek.h
> +++ b/drivers/ufs/host/ufs-mediatek.h
> @@ -26,6 +26,44 @@
> #define REG_UFS_DEBUG_SEL_B2 0x22D8
> #define REG_UFS_DEBUG_SEL_B3 0x22DC
>
> +/*
> + * Details of UIC Errors
> + */
> +static const u8 *ufs_uic_err_str[] = {
> + "PHY Adapter Layer",
> + "Data Link Layer",
> + "Network Link Layer",
> + "Transport Link Layer",
> + "DME"
> +};
Why type u8 for strings instead of char?
Please define arrays in .c files. Otherwise one copy of the array will
be included in each source file this header file is included in.
Thanks,
Bart.
next prev parent reply other threads:[~2022-07-27 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 3:44 [PATCH v2 0/5] scsi: ufs-mediatek: Provide features and fixes in MediaTek platforms Stanley Chu
2022-07-27 3:44 ` [PATCH v2 1/5] scsi: ufs: ufs-mediatek: Remove redundant header files Stanley Chu
2022-07-27 17:55 ` Bart Van Assche
2022-07-28 1:33 ` Stanley Chu
2022-07-27 3:44 ` [PATCH v2 2/5] scsi: ufs: ufs-mediatek: Provide detailed description for UIC errors Stanley Chu
2022-07-27 17:57 ` Bart Van Assche [this message]
2022-07-28 2:26 ` Stanley Chu
2022-07-27 3:44 ` [PATCH v2 3/5] scsi: ufs: ufs-mediatek: Dump more registers Stanley Chu
2022-07-27 3:44 ` [PATCH v2 4/5] scsi: ufs: ufs-mediatek: Fix performance scaling Stanley Chu
2022-07-27 3:44 ` [PATCH v2 5/5] scsi: ufs: ufs-medaitek: Support clk-scaling to optimize power consumption Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa60e605-a881-79aa-b9ed-9c8bdf06778f@acm.org \
--to=bvanassche@acm.org \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mason.zhang@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=tun-yu.yu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®