From: "Grant Likely" <grant.likely@secretlab.ca>
To: "Akinobu Mita" <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net,
akonovalov@ru.mvista.com, linuxppc@ozlabs.org, adaplas@gmail.com
Subject: Re: [PATCH 6/6] Xilinxfb: add of_platform bus binding
Date: Mon, 1 Oct 2007 10:46:38 -0600 [thread overview]
Message-ID: <fa686aa40710010946s55e3cf19w1e91a4e5c48b3dd6@mail.gmail.com> (raw)
In-Reply-To: <961aa3350710010942y42aef8eax6fb54354184b4cc1@mail.gmail.com>
On 10/1/07, Akinobu Mita <akinobu.mita@gmail.com> wrote:
> 2007/10/2, Grant Likely <grant.likely@secretlab.ca>:
>
> > static int __init
> > xilinxfb_init(void)
> > {
> > - /*
> > - * No kernel boot options used,
> > - * so we just need to register the driver
> > - */
> > + int rc;
> > + rc = xilinxfb_of_register();
> > + if (rc)
> > + return rc;
> > +
> > return platform_driver_register(&xilinxfb_platform_driver);
>
> Is it better to add error handling for platform_driver_register()?
Right, good catch. I'll fix that
Thanks!
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195
next prev parent reply other threads:[~2007-10-01 16:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 15:57 [PATCH 0/6] Patch series to add of_platform binding to xilinxfb Grant Likely
2007-10-01 15:57 ` [PATCH 1/6] Xilinxfb: add banner output to probe routine when DEBUG is defined Grant Likely
2007-10-04 12:05 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 2/6] Xilinxfb: Replace calls to printk with dev_dbg, dev_err, etc Grant Likely
2007-10-04 12:06 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 3/6] Xilinxfb: rename failout labels to reflect failure Grant Likely
2007-10-04 12:06 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 4/6] xilinxfb: Split device setup from bus binding Grant Likely
2007-10-04 12:07 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 5/6] Xilinxfb: cleanup platform_bus binding to use platform bus API Grant Likely
2007-10-04 12:07 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 6/6] Xilinxfb: add of_platform bus binding Grant Likely
2007-10-01 16:42 ` Akinobu Mita
2007-10-01 16:46 ` Grant Likely [this message]
2007-10-04 12:11 ` Andrei Konovalov
2007-10-03 0:15 ` [Linux-fbdev-devel] [PATCH 0/6] Patch series to add of_platform binding to xilinxfb Antonino A. Daplas
2007-10-09 4:43 ` Grant Likely
2007-10-09 5:04 ` Antonino A. Daplas
2007-10-09 17:39 ` Grant Likely
2007-10-09 21:06 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa40710010946s55e3cf19w1e91a4e5c48b3dd6@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=adaplas@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=akonovalov@ru.mvista.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®